mirror of
https://github.com/opensourcepos/opensourcepos.git
synced 2026-09-13 05:47:23 -04:00
bugfix(items, validation): reject unsafe tax names and fix payments temp table collision - Add unicode_alpha_numeric_punct rule (OSPOSRules) to allow accented/CJK chars in text fields while blocking HTML-unsafe chars (<, >) as defense-in-depth against injection - Items controller: extract validateItemFields/validateBulkUpdateFields, validate tax_names on save and bulk update using new rule; add shared validateFields helper in Secure_Controller to DRY up validation + JSON error response - Escape tax_group output in sales/quote.php and receipt_email.php views to harden output encoding at render time - Rename sales_payments_temp -> sales_report_payments_temp (Summary_report) and -> sales_search_payments_temp (Sale model) to avoid name collision between concurrently-created temp tables - AGENTS.md: document alignment rule for => columns when inserting new language keys Tests: - Add ItemsControllerTest covering postSave/bulkupdate tax_names validation - Reject <, > in tax_names on /items/save and /items/bulkupdate - Verify unicode and apostrophe-containing tax names are accepted - Cover CSV import helpers: header generation (basic, multiple locations, attributes), stock-location/attribute header builders, get_csv_file parsing (plain, BOM-prefixed, multi-row) - Validate required-header detection for import templates - Remove outdated tax name test from SalesControllerTest - Simplify Database class references in SalesControllerTest i18n: - Add tax_name_invalid translation to Items.php for 20+ locales, inserted alphabetically after tax_category in each file - Normalize quote style in ar-EG/Items.php to single quotes - Add ka/Items.php Georgian locale scaffold Signed-off-by: objecttothis <17935339+objecttothis@users.noreply.github.com>
176 lines
4.7 KiB
PHP
176 lines
4.7 KiB
PHP
<?php
|
|
|
|
namespace App\Controllers;
|
|
|
|
use App\Models\Employee;
|
|
use App\Models\Module;
|
|
use CodeIgniter\HTTP\Exceptions\RedirectException;
|
|
use CodeIgniter\HTTP\ResponseInterface;
|
|
use CodeIgniter\Model;
|
|
use CodeIgniter\Session\Session;
|
|
use Config\OSPOS;
|
|
use Config\Services;
|
|
|
|
/**
|
|
* Controllers that are considered secure extend Secure_Controller, optionally a $module_id can
|
|
* be set to also check if a user can access a particular module in the system.
|
|
*
|
|
* @property employee employee
|
|
* @property module module
|
|
* @property array global_view_data
|
|
* @property session session
|
|
*
|
|
*/
|
|
class Secure_Controller extends BaseController
|
|
{
|
|
public array $global_view_data;
|
|
protected Employee $employee;
|
|
protected Module $module;
|
|
protected Session $session;
|
|
|
|
/**
|
|
* @param string $module_id
|
|
* @param string|null $submodule_id
|
|
* @param string|null $menu_group
|
|
*/
|
|
public function __construct(string $module_id = '', ?string $submodule_id = null, ?string $menu_group = null)
|
|
{
|
|
$this->employee = model(Employee::class);
|
|
$this->module = model(Module::class);
|
|
$config = config(OSPOS::class)->settings;
|
|
$validation = Services::validation();
|
|
|
|
$logged_in_employee_info = $this->employee->get_logged_in_employee_info();
|
|
if (
|
|
!$this->employee->has_module_grant($module_id, $logged_in_employee_info->person_id)
|
|
|| (isset($submodule_id) && !$this->employee->has_module_grant($submodule_id, $logged_in_employee_info->person_id))
|
|
) {
|
|
throw new RedirectException("no_access/$module_id/$submodule_id");
|
|
}
|
|
|
|
// Load up global global_view_data visible to all the loaded views
|
|
$this->session = session();
|
|
if ($menu_group == null) {
|
|
$menu_group = $this->session->get('menu_group');
|
|
} else {
|
|
$this->session->set('menu_group', $menu_group);
|
|
}
|
|
|
|
$allowed_modules = $menu_group == 'home'
|
|
? $this->module->get_allowed_home_modules($logged_in_employee_info->person_id)
|
|
: $this->module->get_allowed_office_modules($logged_in_employee_info->person_id);
|
|
|
|
$this->global_view_data = [];
|
|
foreach ($allowed_modules->getResult() as $module) {
|
|
$this->global_view_data['allowed_modules'][] = $module;
|
|
}
|
|
|
|
$this->global_view_data += [
|
|
'user_info' => $logged_in_employee_info,
|
|
'controller_name' => $module_id,
|
|
'config' => $config
|
|
];
|
|
view('viewData', $this->global_view_data);
|
|
}
|
|
|
|
public function sanitizeSortColumn($headers, $field, $default): string
|
|
{
|
|
return $field != null && in_array($field, array_keys(array_merge(...$headers))) ? $field : $default;
|
|
}
|
|
|
|
/**
|
|
* Validates the given rules and, on failure, returns a JSON error response.
|
|
*
|
|
* @param array $rules
|
|
* @param array $messages
|
|
* @param mixed $id
|
|
* @return ResponseInterface|null
|
|
*/
|
|
protected function validateFields(array $rules, array $messages, $id = NEW_ENTRY): ?ResponseInterface
|
|
{
|
|
if (!$this->validate($rules, $messages)) {
|
|
$errors = $this->validator->getErrors();
|
|
|
|
return $this->response->setJSON(['success' => false, 'message' => reset($errors), 'id' => $id]);
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* AJAX function used to confirm whether values sent in the request are numeric
|
|
* @return ResponseInterface
|
|
* @noinspection PhpUnused
|
|
*/
|
|
public function getCheckNumeric(): ResponseInterface
|
|
{
|
|
foreach ($this->request->getGet() as $value) {
|
|
if (parse_decimals($value) === false) {
|
|
return $this->response->setJSON('false');
|
|
}
|
|
}
|
|
return $this->response->setJSON('true');
|
|
}
|
|
|
|
/**
|
|
* @param $key
|
|
* @return mixed|void
|
|
*/
|
|
public function getConfig($key)
|
|
{
|
|
if (isset($config[$key])) {
|
|
return $config[$key];
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @return false
|
|
*/
|
|
public function getIndex()
|
|
{
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* @return false
|
|
*/
|
|
public function getSearch()
|
|
{
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* @return false
|
|
*/
|
|
public function suggest_search()
|
|
{
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* @param int $data_item_id
|
|
* @return false
|
|
*/
|
|
public function getView(int $data_item_id = -1)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* @param int $data_item_id
|
|
* @return ResponseInterface|false
|
|
*/
|
|
public function postSave(int $data_item_id = -1): ResponseInterface|false
|
|
{
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* @return false
|
|
*/
|
|
public function postDelete()
|
|
{
|
|
return false;
|
|
}
|
|
}
|