Files
opensourcepos/app/Libraries/MY_Migration.php
Travis Garrison 01166ae775 fix(login): distinguish DB unavailable from empty install
`getCurrentVersion()` previously returned `int` with 0 used for both
\"empty database\" and \"DB connection failure\". This conflated two
distinct states, causing login to skip auth when DB was unreachable.

Changes:
- Return type widened to `?int`: null = DB unavailable, 0 = confirmed
  empty DB (new install), positive int = migrated
- Login controller now returns 503 on null (DB error) before checking
  isNewInstall
- isNewInstall gate now uses `=== 0` instead of falsy check

Signed-off-by: Travis Garrison <travis@chiraqbookstore.com>
2026-07-30 15:15:33 +04:00

163 lines
4.2 KiB
PHP

<?php
namespace App\Libraries;
use CodeIgniter\Database\MigrationRunner;
use Config\Database;
use Exception;
use stdClass;
class MY_Migration extends MigrationRunner
{
/**
* @return bool
*/
public function isLatest(): bool
{
$latestVersion = $this->getLatestMigration();
$currentVersion = $this->getCurrentVersion();
return $latestVersion === $currentVersion;
}
/**
* @return int
*/
public function getLatestMigration(): int
{
$migrations = $this->findMigrations();
return (int) basename(end($migrations)->version);
}
/**
* Gets the database version number
*
* @return int|null The version number of the last successfully run database migration,
* 0 for a confirmed empty database, or null if the database is unavailable.
*/
public static function getCurrentVersion(): ?int
{
try {
$db = Database::connect();
if ($db->tableExists('migrations')) {
$builder = $db->table('migrations');
$builder->select('version')->orderBy('version', 'DESC')->limit(1);
$result = $builder->get()->getRow();
return $result ? (int) $result->version : 0;
}
} catch (Exception $e) {
// Database unavailable — distinct from a confirmed empty database.
// Catches mysqli_sql_exception which is not a DatabaseException.
return null;
}
return 0;
}
/**
* @return void
*/
public function migrateToCI4(): void
{
$ci3_migrations_version = $this->ci3MigrationsExists();
if ($ci3_migrations_version) {
$this->migrateTable($ci3_migrations_version);
}
}
/**
* Checks to see if a ci3 version of the migrations table exists
*
* @return bool|string The version number of the last CI3 migration to run or false if the table is CI4 or doesn't exist
*/
private function ci3MigrationsExists(): bool|string
{
try {
if ($this->db->tableExists('migrations') && !$this->db->fieldExists('id', 'migrations')) {
$builder = $this->db->table('migrations');
$builder->select('version');
$result = $builder->get()->getRow();
return $result ? $result->version : false;
}
} catch (Exception $e) {
// Database not available yet (e.g. fresh install before schema).
// Catches mysqli_sql_exception which is not a DatabaseException.
}
return false;
}
/**
* @param string $ci3_migrations_version
* @return void
*/
private function migrateTable(string $ci3_migrations_version): void
{
$this->convertTable();
$available_migrations = $this->getAvailableMigrations();
foreach ($available_migrations as $version => $path) {
if ($version > (int)$ci3_migrations_version) {
break;
}
$migration = new stdClass();
$migration->version = $version;
$migration->class = $path;
$migration->namespace = 'App';
$this->addHistory($migration, 1);
}
}
/**
* @return void
*/
public function up(): void
{
// TODO: Implement up() method.
}
/**
* @return void
*/
public function down(): void
{
// TODO: Implement down() method.
}
/**
* @return array
*/
private function getAvailableMigrations(): array
{
$migrations = $this->findMigrations();
$explodedMigrations = [];
foreach ($migrations as $migration) {
$version = substr($migration->uid, 0, 14);
$path = substr($migration->uid, 14);
$explodedMigrations[$version] = $path;
}
ksort($explodedMigrations);
return $explodedMigrations;
}
/**
* Converts the CI3 migrations database to CI4
* @return void
*/
public function convertTable(): void
{
$forge = Database::forge();
$forge->dropTable('migrations');
$this->ensureTable();
}
}