mirror of
https://github.com/opensourcepos/opensourcepos.git
synced 2026-10-31 12:39:56 -04:00
jekkosandobjecttothis
625bb3536a
* fix(taxes): reject negative tax rates and percentages
Reject negative tax values across all tax entry points so they can
never be persisted and produce inverted sales totals:
- Items::postSave / postBulkUpdate: validate tax_percents.* as
nonNegativeDecimal (was unvalidated, persisted raw).
- Items::save_tax_data (CSV import): fail the row on a negative
Tax N Percent instead of silently dropping the tax.
- Taxes::postSave: reject negative tax_rate before saving.
- Config::postSaveTax: reject negative default tax rates.
Adds non-negative regression tests for Items, Taxes and Config, plus
boundary tests proving a zero tax rate/percent is still accepted. New
language strings for the rejection messages.
* test: adopt test{Method}_{Purpose} naming convention for new tests
Align the negative-tax test method names with the convention established
in ConfigTest (testPostSave_RejectsNegativeTaxPercent, etc.), per review.
* fix(config): add language entries to all locales, extract TaxFixtureTrait
* fix(i18n): place tax_rate_non_negative in alphabetical order
Move the new tax_rate_non_negative entry to its correct alphabetical
position (after tax_rate_error_adding_updating) in all locale files.
---------
Co-authored-by: objecttothis <17935339+objecttothis@users.noreply.github.com>
85 lines
4.1 KiB
PHP
85 lines
4.1 KiB
PHP
<?php
|
|
|
|
return [
|
|
"add_exception" => "",
|
|
"cascade" => "",
|
|
"cascade_sequence" => "",
|
|
"city" => "",
|
|
"code" => "",
|
|
"confirm_delete" => "",
|
|
"confirm_restore" => "",
|
|
"default_tax_category" => "",
|
|
"default_tax_rate" => "",
|
|
"error_adding_updating" => "",
|
|
"group_seq" => "",
|
|
"jurisdiction_name" => "",
|
|
"name" => "",
|
|
"new" => "",
|
|
"no_taxes" => "",
|
|
"no_taxes_to_display" => "",
|
|
"reporting_authority" => "",
|
|
"round_half_down" => "",
|
|
"round_half_even" => "",
|
|
"round_half_odd" => "",
|
|
"round_half_up" => "",
|
|
"rounding_code" => "",
|
|
"sales_tax" => "",
|
|
"sales_tax_by_invoice" => "",
|
|
"sequence" => "",
|
|
"state" => "",
|
|
"successful_deleted" => "",
|
|
"tax_categories" => "",
|
|
"tax_categories_configuration" => "",
|
|
"tax_categories_saved_successfully" => "",
|
|
"tax_categories_saved_unsuccessfully" => "",
|
|
"tax_category" => "",
|
|
"tax_category_code" => "",
|
|
"tax_category_duplicate" => "",
|
|
"tax_category_invalid_chars" => "",
|
|
"tax_category_name" => "",
|
|
"tax_category_new" => "",
|
|
"tax_category_required" => "",
|
|
"tax_code" => "",
|
|
"tax_code_cannot_be_deleted" => "",
|
|
"tax_code_duplicate" => "",
|
|
"tax_code_invalid_chars" => "",
|
|
"tax_code_name" => "",
|
|
"tax_code_required" => "",
|
|
"tax_code_successful_deleted" => "",
|
|
"tax_code_successful_updated" => "",
|
|
"tax_code_successful_updating" => "",
|
|
"tax_code_successfully_added" => "",
|
|
"tax_code_type" => "",
|
|
"tax_codes" => "",
|
|
"tax_codes_configuration" => "",
|
|
"tax_codes_saved_successfully" => "",
|
|
"tax_codes_saved_unsuccessfully" => "",
|
|
"tax_excluded" => "",
|
|
"tax_group" => "",
|
|
"tax_group_not_unique" => "",
|
|
"tax_group_sequence" => "",
|
|
"tax_included" => "",
|
|
"tax_jurisdiction" => "",
|
|
"tax_jurisdiction_duplicate" => "",
|
|
"tax_jurisdiction_invalid_chars" => "",
|
|
"tax_jurisdiction_required" => "",
|
|
"tax_jurisdictions" => "",
|
|
"tax_jurisdictions_configuration" => "",
|
|
"tax_jurisdictions_saved_successfully" => "",
|
|
"tax_jurisdictions_saved_unsuccessfully" => "",
|
|
"tax_rate" => "",
|
|
"tax_rate_configuration" => "",
|
|
"tax_rate_error_adding_updating" => "",
|
|
"tax_rate_non_negative" => "",
|
|
"tax_rate_numeric" => "",
|
|
"tax_rate_required" => "",
|
|
"tax_rate_successful_updated" => "",
|
|
"tax_rate_successfully_added" => "",
|
|
"tax_rates" => "",
|
|
"tax_rates_configuration" => "",
|
|
"tax_rounding" => "",
|
|
"tax_type" => "",
|
|
"update" => "",
|
|
"vat_tax" => "",
|
|
];
|