mirror of
https://github.com/opensourcepos/opensourcepos.git
synced 2026-10-29 03:28:53 -04:00
objecttothisandClaude Sonnet 5
af48fa4357
Adds DatabaseBootstrapTrait and OsposConfigFixtureTrait to replace duplicated per-file setUp()/tearDown() bootstrap and OSPOS config mock boilerplate across test classes, bringing them in line with the ItemsControllerTest gold-standard shape. Fixes the real root cause of tabular_helperTest's suite-order-dependent failure: dropAllForeignKeyConstraints()/foreignKeyExists()/ dropColumnIfExists() temporarily blank the shared connection's DBPrefix via overridePrefix() but never restored it if the query between the two calls threw (e.g. migration_helperTest's mocked-failure tests) - permanently corrupting prefixed table lookups for the rest of the process. Wrapped each in try/finally. Also widens executeScript() to accept an explicit connection so migration SQL can't silently run against the wrong DB group. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
90 lines
2.8 KiB
PHP
90 lines
2.8 KiB
PHP
<?php
|
|
|
|
namespace Tests\Models;
|
|
|
|
use App\Models\Item_quantity;
|
|
use CodeIgniter\Test\CIUnitTestCase;
|
|
use CodeIgniter\Test\DatabaseTestTrait;
|
|
use Tests\Support\ConcurrentDbRaceTrait;
|
|
use Tests\Support\DatabaseBootstrapTrait;
|
|
use Tests\Support\ItemFixtureTrait;
|
|
|
|
/**
|
|
* Regression tests: changeQuantity() must apply
|
|
* its write in a single atomic upsert, so that two concurrent sales of the
|
|
* same item/location can never both read the same stale quantity and
|
|
* oversell stock. Unlike the gift card and reward point spends, there is
|
|
* deliberately no floor guard here (see the fix's scope note) — negative
|
|
* stock is allowed today and this fix does not change that.
|
|
*/
|
|
class ItemQuantityTest extends CIUnitTestCase
|
|
{
|
|
use DatabaseTestTrait;
|
|
use DatabaseBootstrapTrait;
|
|
use ConcurrentDbRaceTrait;
|
|
use ItemFixtureTrait;
|
|
|
|
protected $migrate = true;
|
|
protected $migrateOnce = true;
|
|
protected $refresh = false;
|
|
protected $namespace = null;
|
|
|
|
private const LOCATION_ID = 1;
|
|
|
|
protected function setUp(): void
|
|
{
|
|
$this->resetDatabaseOnce();
|
|
|
|
parent::setUp();
|
|
}
|
|
|
|
protected function createItemQuantityRow(int $itemId, float $quantity): void
|
|
{
|
|
\Config\Database::connect()->table('item_quantities')->insert([
|
|
'item_id' => $itemId,
|
|
'location_id' => self::LOCATION_ID,
|
|
'quantity' => $quantity,
|
|
]);
|
|
}
|
|
|
|
public function testDecrementQuantitySucceeds(): void
|
|
{
|
|
$itemId = $this->createTestItem();
|
|
$this->createItemQuantityRow($itemId, 10);
|
|
$itemQuantityModel = model(Item_quantity::class);
|
|
|
|
$result = $itemQuantityModel->changeQuantity($itemId, self::LOCATION_ID, -3);
|
|
|
|
$this->assertTrue($result);
|
|
$this->assertEqualsWithDelta(7.0, $this->getItemQuantity($itemId, self::LOCATION_ID), 0.001);
|
|
}
|
|
|
|
public function testDecrementQuantityAllowsGoingNegative(): void
|
|
{
|
|
$itemId = $this->createTestItem();
|
|
$this->createItemQuantityRow($itemId, 5);
|
|
$itemQuantityModel = model(Item_quantity::class);
|
|
|
|
$result = $itemQuantityModel->changeQuantity($itemId, self::LOCATION_ID, -8);
|
|
|
|
$this->assertTrue($result);
|
|
$this->assertEqualsWithDelta(-3.0, $this->getItemQuantity($itemId, self::LOCATION_ID), 0.001);
|
|
}
|
|
|
|
public function testDecrementQuantityConcurrentDecrementsBothApply(): void
|
|
{
|
|
$itemId = $this->createTestItem();
|
|
$this->createItemQuantityRow($itemId, 10);
|
|
|
|
[$result1, $result2] = $this->raceTwoProcesses(
|
|
'itemQuantity',
|
|
[$itemId, self::LOCATION_ID, -3.0],
|
|
[$itemId, self::LOCATION_ID, -3.0]
|
|
);
|
|
|
|
$this->assertTrue($result1);
|
|
$this->assertTrue($result2);
|
|
$this->assertEqualsWithDelta(4.0, $this->getItemQuantity($itemId, self::LOCATION_ID), 0.001);
|
|
}
|
|
}
|