mirror of
https://github.com/openSUSE/osem.git
synced 2026-06-11 17:25:15 -04:00
When using :pluck, ActiveRecord trigger the query immediately.
The above is a behavior we probably want to avoid, because
implies a query to the database regarless of the role or
permission.
** Before
osem_1 | 07:39:11 web.1 | Started GET "/" for 172.20.0.1 at 2019-07-1207:39:11 +0000
osem_1 | 07:39:11 web.1 | (0.3ms) SELECT
"conferences"."custom_domain" FROM "conferences" WHERE
("conferences"."custom_domain" IS NOT NULL) ORDER BY start_date DESC
osem_1 | 07:39:11 web.1 | Processing by ConferencesController#index as HTML
osem_1 | 07:39:11 web.1 | (1.3ms) SELECT "events"."id" FROM
"events" WHERE "events"."state" = $ 1 [["state", "confirmed"]]
osem_1 | 07:39:11 web.1 | ↳ app/models/ability.rb:39:in `not_signed_in'
osem_1 | 07:39:11 web.1 | Rendering layouts/application.html.haml
osem_1 | 07:39:11 web.1 | Rendering conferences/index.html.haml within layouts/application
** After
osem_1 | 07:43:18 web.1 | Started GET "/" for 172.20.0.1 at 2019-07-1207:43:18 +0000
osem_1 | 07:43:19 web.1 | (0.2ms) SELECT
"conferences"."custom_domain" FROM "conferences" WHERE
("conferences"."custom_domain" IS NOT NULL) ORDER BY start_date DESC
osem_1 | 07:43:19 web.1 | Processing by ConferencesController#index as HTML
osem_1 | 07:43:19 web.1 | Rendering layouts/application.html.haml
osem_1 | 07:43:19 web.1 | Rendering conferences/index.html.haml within layouts/application
177 lines
6.1 KiB
Ruby
177 lines
6.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Ability
|
|
include CanCan::Ability
|
|
|
|
# Initializes the ability class
|
|
def initialize(user)
|
|
user ||= User.new
|
|
|
|
if user.new_record?
|
|
not_signed_in
|
|
else
|
|
signed_in(user)
|
|
common_abilities_for_admins(user) if user.roles.any? || user.is_admin?
|
|
end
|
|
end
|
|
|
|
# Abilities for not signed in users (guests)
|
|
def not_signed_in
|
|
can [:index, :conferences, :code_of_conduct], Organization
|
|
can [:index], Conference
|
|
can [:show], Conference do |conference|
|
|
conference.splashpage&.public == true
|
|
end
|
|
# Can view the schedule
|
|
can [:schedule, :events], Conference do |conference|
|
|
conference.program.cfp && conference.program.schedule_public
|
|
end
|
|
|
|
can :show, Event do |event|
|
|
event.state == 'confirmed'
|
|
end
|
|
|
|
can [:show, :events, :app], Schedule do |schedule|
|
|
schedule.program.schedule_public
|
|
end
|
|
|
|
# can view Commercials of confirmed Events
|
|
can :show, Commercial, commercialable: Event.where(state: 'confirmed')
|
|
can [:show, :create], User
|
|
|
|
can [:index, :show], Survey, surveyable_type: 'Conference'
|
|
|
|
# Things that are possible without ichain enabled that are **not*+ possible with ichain mode enabled.
|
|
if ENV['OSEM_ICHAIN_ENABLED'] != 'true'
|
|
# There is no reliable way for this workflow (enable not logged in users to fill out a form, then telling
|
|
# them to sign up once they submit) in ichain. So enable it only without ichain.
|
|
|
|
# FIXME: The following abilities need to be checked. Are they about the type of workflow mentioned above? Or are
|
|
# they just here because they worked in development mode (without ichain). We are suspicious that it's the latter!
|
|
can :show, Registration do |registration|
|
|
registration.new_record?
|
|
end
|
|
|
|
can [:new, :create], Registration do |registration|
|
|
conference = registration.conference
|
|
conference.registration_open? && registration.new_record? && !conference.registration_limit_exceeded?
|
|
end
|
|
|
|
can :show, Event do |event|
|
|
event.new_record?
|
|
end
|
|
|
|
can [:new, :create], Event do |event|
|
|
event.program.cfp_open? && event.new_record?
|
|
end
|
|
end
|
|
end
|
|
|
|
# Abilities for signed in users
|
|
def signed_in(user)
|
|
# Abilities from not_signed_in user are also inherited
|
|
not_signed_in
|
|
can :manage, User, id: user.id
|
|
|
|
can :manage, Registration, user_id: user.id
|
|
|
|
can [:new, :create], Registration do |registration|
|
|
conference = registration.conference
|
|
if conference.user_registered? user
|
|
false
|
|
elsif conference.program.speakers.confirmed.include?(user) && conference.registration_period
|
|
true
|
|
else
|
|
conference.registration_open? && !conference.registration_limit_exceeded?
|
|
end
|
|
end
|
|
|
|
can :index, Organization
|
|
can :index, Ticket
|
|
can :manage, TicketPurchase, user_id: user.id
|
|
can [:new, :create], Payment, user_id: user.id
|
|
can [:index, :show], PhysicalTicket, user: user
|
|
|
|
can [:new, :create], Booth do |booth|
|
|
booth.new_record? && booth.conference.program.cfps.for_booths.try(:open?)
|
|
end
|
|
|
|
can [:edit, :update, :index, :show], Booth do |booth|
|
|
booth.users.include?(user)
|
|
end
|
|
|
|
can [:create, :destroy], Subscription, user_id: user.id
|
|
|
|
can [:new, :create], Event do |event|
|
|
event.program.cfp_open? && event.new_record?
|
|
end
|
|
|
|
can [:update, :show, :index], Event do |event|
|
|
event.users.include?(user)
|
|
end
|
|
|
|
# can manage the commercials of their own events
|
|
can :manage, Commercial, commercialable_type: 'Event', commercialable_id: user.events.pluck(:id)
|
|
|
|
# can view and reply to a survey
|
|
can [:index, :show, :reply], Survey, surveyable_type: 'Conference'
|
|
can [:index, :show, :reply], Survey, surveyable_type: 'Registration', surveyable_id: user.registrations.pluck(:conference_id)
|
|
|
|
# TODO: this needs to check for more, eg.
|
|
# if survey target is after_conference, check whether or not the conference is over
|
|
# if not, do not allow replies.
|
|
|
|
# do not allow replies before the start_date or after the end_date of survey
|
|
cannot :reply, Survey do |survey|
|
|
survey.start_date > Time.current || survey.end_date < Time.current
|
|
end
|
|
|
|
can [:destroy], Openid
|
|
|
|
can [:new, :create], Track do |track|
|
|
track.new_record? && track.program.cfps.for_tracks.try(:open?)
|
|
end
|
|
|
|
can [:index, :show, :restart, :confirm, :withdraw], Track, submitter_id: user.id
|
|
|
|
can [:edit, :update], Track do |track|
|
|
user == track.submitter && !(track.accepted? || track.confirmed?)
|
|
end
|
|
end
|
|
|
|
# Abilities for users with roles wandering around in non-admin views.
|
|
def common_abilities_for_admins(user)
|
|
can :access, Admin
|
|
can :manage, :all if user.is_admin?
|
|
|
|
conf_ids_for_organizer = Conference.with_role(:organizer, user).pluck(:id)
|
|
conf_ids_for_cfp = Conference.with_role(:cfp, user).pluck(:id)
|
|
conf_ids_for_info_desk = Conference.with_role(:info_desk, user).pluck(:id)
|
|
|
|
if conf_ids_for_organizer
|
|
# To access splashpage of their conference if it is not public
|
|
can :show, Conference, id: conf_ids_for_organizer
|
|
# To access conference/proposals/registrations
|
|
can :manage, Registration, conference_id: conf_ids_for_organizer
|
|
# To access conference/proposals
|
|
can :manage, Event, program: { conference_id: conf_ids_for_organizer }
|
|
# To access comment link in menu bar
|
|
can :index, Comment, commentable_type: 'Event',
|
|
commentable_id: Event.where(program_id: Program.where(conference_id: conf_ids_for_organizer).pluck(:id)).pluck(:id)
|
|
end
|
|
|
|
if conf_ids_for_cfp
|
|
# To access comment link in menu bar
|
|
can :index, Comment, commentable_type: 'Event',
|
|
commentable_id: Event.where(program_id: Program.where(conference_id: conf_ids_for_cfp).pluck(:id)).pluck(:id)
|
|
# To access conference/proposals
|
|
can :manage, Event, program: { conference_id: conf_ids_for_cfp }
|
|
end
|
|
|
|
if conf_ids_for_info_desk
|
|
# To access conference/proposals/registrations
|
|
can :manage, Registration, conference_id: conf_ids_for_info_desk
|
|
end
|
|
end
|
|
end
|