From 019931da8f5484b0a33dfb23ec7fb51ff9668d07 Mon Sep 17 00:00:00 2001 From: Zoltan Kochan Date: Sat, 9 Dec 2017 20:24:15 +0200 Subject: [PATCH] feat: returning the finishing param in PackageResponse object --- src/connectPackageRequester.ts | 4 +++- test/index.ts | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/connectPackageRequester.ts b/src/connectPackageRequester.ts index 90f13e88ae..b823be6a79 100644 --- a/src/connectPackageRequester.ts +++ b/src/connectPackageRequester.ts @@ -1,4 +1,5 @@ import { + PackageResponse, RequestPackageFunction, RequestPackageOptions, Resolution, @@ -73,7 +74,7 @@ function requestPackage ( waiters: object, wantedDependency: WantedDependency, options: RequestPackageOptions, -) { +): Promise { const msgId = uuid.v4() const fetchingManifest = waiters['add'](`manifestResponse:${msgId}`) // tslint:disable-line @@ -83,6 +84,7 @@ function requestPackage ( return Object.assign(packageResponse, { fetchingFiles, fetchingManifest, + finishing: Promise.all([fetchingManifest, fetchingFiles]).then(() => undefined), }) }) diff --git a/test/index.ts b/test/index.ts index faad77d7b8..47ed3644aa 100644 --- a/test/index.ts +++ b/test/index.ts @@ -60,6 +60,9 @@ test('server', async t => { const files = await response['fetchingFiles'] as PackageFilesResponse t.notOk(files.fromStore) t.ok(files.filenames.indexOf('package.json') !== -1) + t.ok(response['finishing']) + + await response['finishing'] server.close() requestPackage['end']() // tslint:disable-line