mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-04-28 02:53:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't print the same deprecation warning multiple times (#5149)

Browse Source
This commit is contained in:
Zoltan Kochan
2022-08-03 16:05:07 +03:00
committed by GitHub
parent 65c4260dee
commit 0321ca32a4
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.changeset/clean-ears-jam.md Normal file
View File

@@ -0,0 +1,6 @@
---
"@pnpm/resolve-dependencies": patch
"pnpm": patch
---
Don't print the same deprecation warning multiple times.

8
packages/resolve-dependencies/src/resolveDependencies.ts
View File

@@ -925,7 +925,9 @@ async function resolveDependency (
status: 'resolved',
})
ctx.resolvedPackagesByDepPath[depPath] = await getResolvedPackage({
// WARN: It is very important to keep this sync
// Otherwise, deprecation messages for the same package might get written several times
ctx.resolvedPackagesByDepPath[depPath] = getResolvedPackage({
allowBuild: ctx.allowBuild,
dependencyLockfile: currentPkg.dependencyLockfile,
depPath,
@@ -1016,7 +1018,7 @@ function pkgIsLeaf (pkg: PackageManifest) {
isEmpty(pkg.peerDependencies ?? {})
}
async function getResolvedPackage (
function getResolvedPackage (
options: {
allowBuild?: (pkgName: string) => boolean
dependencyLockfile?: PackageSnapshot
@@ -1029,7 +1031,7 @@ async function getResolvedPackage (
prepare: boolean
wantedDependency: WantedDependency
}
): Promise<ResolvedPackage> {
): ResolvedPackage {
const peerDependencies = peerDependenciesWithoutOwn(options.pkg)
const requiresBuild = (options.allowBuild == null || options.allowBuild(options.pkg.name))