mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-04-10 18:18:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: installing a new dependency with a trailing @

Browse Source 
`pnpm add foo@` should install the latest `foo`

PR #2742
close #2737
This commit is contained in:
Zoltan Kochan
2020-08-01 19:44:14 +03:00
committed by GitHub
parent 24af41f20b
commit 0a8ff3ad3e
3 changed files with 27 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/witty-chicken-eat.md Normal file
View File

@@ -0,0 +1,5 @@
---
"supi": patch
---
Don't fail when installing a dependency with a trailing @.

9
packages/supi/src/utils/getPref.ts
View File

@@ -129,9 +129,12 @@ function getPrefPreferSpecifiedSpec (
) {
const prefix = getPrefix(opts.alias, opts.name)
if (opts.specRaw?.startsWith(`${opts.alias}@${prefix}`)) {
const selector = versionSelectorType(opts.specRaw.substr(`${opts.alias}@${prefix}`.length))
if (selector && (selector.type === 'version' || selector.type === 'range')) {
return opts.specRaw.substr(opts.alias.length + 1)
const range = opts.specRaw.substr(`${opts.alias}@${prefix}`.length)
if (range) {
const selector = versionSelectorType(range)
if (selector && (selector.type === 'version' || selector.type === 'range')) {
return opts.specRaw.substr(opts.alias.length + 1)
}
}
}
return `${prefix}${createVersionSpec(opts.version, opts.pinnedVersion)}`

16
packages/supi/test/install/misc.ts
View File

@@ -188,6 +188,22 @@ test('modules without version spec, with custom tag config', async (t) => {
await project.storeHas('dep-of-pkg-with-1-dep', '100.0.0')
})
test('modules without version spec but with a trailing @', async (t) => {
const project = prepareEmpty(t)
await addDependenciesToPackage({}, ['dep-of-pkg-with-1-dep@'], await testDefaults())
await project.has('dep-of-pkg-with-1-dep')
})
test('aliased modules without version spec but with a trailing @', async (t) => {
const project = prepareEmpty(t)
await addDependenciesToPackage({}, ['foo@npm:dep-of-pkg-with-1-dep@'], await testDefaults())
await project.has('foo')
})
test('installing a package by specifying a specific dist-tag', async (t) => {
const project = prepareEmpty(t)