From 0c11e1a07f5435cfda61adc096f9e2c99019a13b Mon Sep 17 00:00:00 2001 From: Kinrany Date: Sat, 13 Feb 2021 22:50:30 +0300 Subject: [PATCH] fix: end with \n when `pnpm audit` finds nothing (#3134) * End with \n when `pnpm audit` finds nothing * test: new line in the end of audit output Co-authored-by: Zoltan Kochan --- .changeset/gentle-geese-camp.md | 5 +++++ packages/plugin-commands-audit/src/audit.ts | 2 +- packages/plugin-commands-audit/test/index.ts | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changeset/gentle-geese-camp.md diff --git a/.changeset/gentle-geese-camp.md b/.changeset/gentle-geese-camp.md new file mode 100644 index 0000000000..4769a91b4d --- /dev/null +++ b/.changeset/gentle-geese-camp.md @@ -0,0 +1,5 @@ +--- +"@pnpm/plugin-commands-audit": patch +--- + +Audit output should always have a new line at the end. diff --git a/packages/plugin-commands-audit/src/audit.ts b/packages/plugin-commands-audit/src/audit.ts index 4ac60c29e3..ae88ad2902 100644 --- a/packages/plugin-commands-audit/src/audit.ts +++ b/packages/plugin-commands-audit/src/audit.ts @@ -141,7 +141,7 @@ export async function handler ( } function reportSummary (vulnerabilities: AuditVulnerabilityCounts, totalVulnerabilityCount: number) { - if (totalVulnerabilityCount === 0) return 'No known vulnerabilities found' + if (totalVulnerabilityCount === 0) return 'No known vulnerabilities found\n' return `${chalk.red(totalVulnerabilityCount)} vulnerabilities found\nSeverity: ${ Object.entries(vulnerabilities) .filter(([auditLevel, vulnerabilitiesCount]) => vulnerabilitiesCount > 0) diff --git a/packages/plugin-commands-audit/test/index.ts b/packages/plugin-commands-audit/test/index.ts index 5193c606a9..b6614166a8 100644 --- a/packages/plugin-commands-audit/test/index.ts +++ b/packages/plugin-commands-audit/test/index.ts @@ -69,7 +69,7 @@ test('audit: no vulnerabilities', async () => { }, }) - expect(stripAnsi(output)).toBe('No known vulnerabilities found') + expect(stripAnsi(output)).toBe('No known vulnerabilities found\n') expect(exitCode).toBe(0) })