mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-04-28 02:53:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

perf(resolve-dependencies): preferredVersions in resolveDependenciesOfImporters (#6748)

Browse Source
This commit is contained in:
Bogdan Savluk
2023-07-02 14:57:30 +02:00
committed by GitHub
parent ba93356018
commit 17e4a3ab13
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/fluffy-eggs-matter.md Normal file
View File

@@ -0,0 +1,5 @@
---
"@pnpm/resolve-dependencies": patch
---
Replacing object spread with a prototype chain, avoiding extra memory allocations in resolveDependenciesOfImporters.

6
pkg-manager/resolve-dependencies/src/resolveDependencies.ts
View File

@@ -395,7 +395,7 @@ async function resolveDependenciesOfImporters (
}
}
const pkgAddressesByImportersWithoutPeers = await Promise.all(zipWith(async (importer, { pkgAddresses, postponedResolutionsQueue, postponedPeersResolutionQueue }) => {
const newPreferredVersions = { ...importer.preferredVersions }
const newPreferredVersions = Object.create(importer.preferredVersions) as PreferredVersions
const currentParentPkgAliases: Record<string, PkgAddress | true> = {}
for (const pkgAddress of pkgAddresses) {
if (currentParentPkgAliases[pkgAddress.alias] !== true) {
@@ -406,8 +406,8 @@ async function resolveDependenciesOfImporters (
}
const resolvedPackage = ctx.resolvedPackagesByDepPath[pkgAddress.depPath]
if (!resolvedPackage) continue // This will happen only with linked dependencies
if (!newPreferredVersions[resolvedPackage.name]) {
newPreferredVersions[resolvedPackage.name] = {}
if (!Object.prototype.hasOwnProperty.call(newPreferredVersions, resolvedPackage.name)) {
newPreferredVersions[resolvedPackage.name] = { ...importer.preferredVersions[resolvedPackage.name] }
}
if (!newPreferredVersions[resolvedPackage.name][resolvedPackage.version]) {
newPreferredVersions[resolvedPackage.name][resolvedPackage.version] = {