fix(build-modules): fix incorrect return in getSubgraphToBuild (#3369)

* fix(build-modules): fix incorrect return in getSubgraphToBuild

* docs: changeset for the last commit
This commit is contained in:
Xingcan LAN
2021-04-20 04:40:21 +08:00
committed by GitHub
parent 7783f64730
commit 1a9b4f8123
2 changed files with 7 additions and 2 deletions

View File

@@ -0,0 +1,5 @@
---
"@pnpm/build-modules": patch
---
Fix incorrect return in getSubgraphToBuild

View File

@@ -145,13 +145,13 @@ function getSubgraphToBuild (
) {
let currentShouldBeBuilt = false
for (const depPath of entryNodes) {
if (!graph[depPath]) return // packages that are already in node_modules are skipped
if (!graph[depPath]) continue // packages that are already in node_modules are skipped
if (nodesToBuild.has(depPath)) {
currentShouldBeBuilt = true
}
if (walked.has(depPath)) continue
walked.add(depPath)
const childShouldBeBuilt = getSubgraphToBuild(graph, R.values(graph[depPath].children), nodesToBuild, walked) === true ||
const childShouldBeBuilt = getSubgraphToBuild(graph, R.values(graph[depPath].children), nodesToBuild, walked) ||
graph[depPath].requiresBuild
if (childShouldBeBuilt) {
nodesToBuild.add(depPath)