mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-04-10 18:18:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): don't fail on skipped optional deps, when calculating depsRequiringBuild (#8404)

Browse Source
This commit is contained in:
Zoltan Kochan
2024-08-11 14:54:27 +02:00
committed by GitHub
parent 9b4f73caaf
commit 39f693ba89
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/brave-pants-drive.md Normal file
View File

@@ -0,0 +1,5 @@
---
"@pnpm/core": patch
---
Don't fail on skipped optional dependencies, when searching for dependencies that should be built.

2
pkg-manager/core/src/install/index.ts
View File

@@ -1420,7 +1420,7 @@ const _installInContext: InstallFunction = async (projects, ctx, opts) => {
const depsRequiringBuild: DepPath[] = []
if (opts.returnListOfDepsRequiringBuild) {
await Promise.all(Object.entries(dependenciesGraph).map(async ([depPath, node]) => {
if (node == null) return // We cannot detect if a skipped optional dependency requires build
if (node?.fetching == null) return // We cannot detect if a skipped optional dependency requires build
const { files } = await node.fetching()
if (files.requiresBuild) {
depsRequiringBuild.push(depPath as DepPath)