From 3eaedeea0bb40bca07518c10fc890e4300aa86e1 Mon Sep 17 00:00:00 2001
From: Zoltan Kochan <z@kochan.io>
Date: Sat, 14 Dec 2019 21:28:46 +0200
Subject: [PATCH] refactor(supi): installSome()

---
 packages/supi/src/install/index.ts | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/packages/supi/src/install/index.ts b/packages/supi/src/install/index.ts
index 32324a721c..936dea339b 100644
--- a/packages/supi/src/install/index.ts
+++ b/packages/supi/src/install/index.ts
@@ -284,7 +284,10 @@ export async function mutateModules (
           break
         }
         case 'installSome': {
-          await installSome(importer)
+          await installSome({
+            ...importer,
+            updatePackageManifest: true,
+          })
           break
         }
         case 'unlink': {
@@ -332,7 +335,12 @@ export async function mutateModules (
 
           // TODO: install only those that were unlinked
           // but don't update their version specs in package.json
-          await installSome({ ...importer, mutation: 'installSome', dependencySelectors: packagesToInstall }, false)
+          await installSome({
+            ...importer,
+            dependencySelectors: packagesToInstall,
+            mutation: 'installSome',
+            updatePackageManifest: false,
+          })
           break
         }
       }
@@ -368,7 +376,7 @@ export async function mutateModules (
       })
     }
 
-    async function installSome (importer: any, updatePackageManifest: boolean = true) { // tslint:disable-line:no-any
+    async function installSome (importer: any) { // tslint:disable-line:no-any
       const currentPrefs = opts.ignoreCurrentPrefs ? {} : getAllDependenciesFromPackage(importer.manifest)
       const optionalDependencies = importer.targetDependenciesField ? {} : importer.manifest.optionalDependencies || {}
       const devDependencies = importer.targetDependenciesField ? {} : importer.manifest.devDependencies || {}
@@ -385,7 +393,6 @@ export async function mutateModules (
       importersToInstall.push({
         pruneDirectDependencies: false,
         ...importer,
-        updatePackageManifest,
         wantedDependencies: wantedDeps.map(wantedDep => ({ ...wantedDep, isNew: true })),
       })
     }