From 4e6fce9db14c310168bd43c41e830b6cf0ed517f Mon Sep 17 00:00:00 2001
From: Zoltan Kochan <z@kochan.io>
Date: Sun, 12 Nov 2017 20:53:25 +0200
Subject: [PATCH] feat: don't show all the stderr output

Many libs use stderr for logging
---
 src/index.ts  | 14 +++-----------
 test/index.ts |  3 ++-
 2 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/src/index.ts b/src/index.ts
index 3934c5840a..e17e21032c 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -163,22 +163,14 @@ export function toOutput$(streamParser: object): Stream<string> {
     })
     .map(xs.of)
 
-  const lifecycleMessages: {[pkgId: string]: {keep: boolean, output: string}} = {}
+  const lifecycleMessages: {[pkgId: string]: string} = {}
   const lifecycleOutput$ = xs.of(
     log$
       .filter((log) => log.name === 'pnpm:lifecycle')
       .map((log: LifecycleLog) => {
         const key = `${log.script}:${log.pkgId}`
-        const keep = lifecycleMessages[key] && lifecycleMessages[key].keep || log.level === 'error'
-        const formattedLine = formatLifecycle(log)
-        const output = keep && lifecycleMessages[key]
-          ? `${lifecycleMessages[key].output}${EOL}${formattedLine}`
-          : formattedLine
-        lifecycleMessages[key] = {
-          keep,
-          output,
-        }
-        return R.values(lifecycleMessages).map((lm) => lm['output']).join(EOL)
+        lifecycleMessages[key] = formatLifecycle(log)
+        return R.values(lifecycleMessages).join(EOL)
       })
       .map((msg) => ({msg})),
   )
diff --git a/test/index.ts b/test/index.ts
index 453aa63960..4c07aedb78 100644
--- a/test/index.ts
+++ b/test/index.ts
@@ -299,7 +299,8 @@ test('groups lifecycle output', t => {
   })
 })
 
-test('prints lifecycle progress', t => {
+// Many libs use stderr for logging, so showing all stderr adds not much value
+test['skip']('prints lifecycle progress', t => {
   const output$ = toOutput$(createStreamParser())
 
   const pkgId = 'registry.npmjs.org/foo/1.0.0'