diff --git a/.changeset/flat-elephants-hammer.md b/.changeset/flat-elephants-hammer.md new file mode 100644 index 0000000000..6708758cde --- /dev/null +++ b/.changeset/flat-elephants-hammer.md @@ -0,0 +1,5 @@ +--- +"@pnpm/resolve-dependencies": major +--- + +Remove `allowBuild` from options. diff --git a/pkg-manager/core/src/install/index.ts b/pkg-manager/core/src/install/index.ts index fc0f8a5a43..69ddfbe974 100644 --- a/pkg-manager/core/src/install/index.ts +++ b/pkg-manager/core/src/install/index.ts @@ -932,8 +932,6 @@ const _installInContext: InstallFunction = async (projects, ctx, opts) => { } = await resolveDependencies( projects, { - // In the next major allow build should be just () => true here always - allowBuild: opts.onlyBuiltDependenciesFile ? () => true : createAllowBuildFunction({ onlyBuiltDependencies: opts.onlyBuiltDependencies, neverBuiltDependencies: opts.neverBuiltDependencies }), allowedDeprecatedVersions: opts.allowedDeprecatedVersions, allowNonAppliedPatches: opts.allowNonAppliedPatches, autoInstallPeers: opts.autoInstallPeers, diff --git a/pkg-manager/resolve-dependencies/src/resolveDependencies.ts b/pkg-manager/resolve-dependencies/src/resolveDependencies.ts index 888a35c38c..1e9f4634af 100644 --- a/pkg-manager/resolve-dependencies/src/resolveDependencies.ts +++ b/pkg-manager/resolve-dependencies/src/resolveDependencies.ts @@ -136,7 +136,6 @@ export interface ResolutionContext { allPeerDepNames: Set autoInstallPeers: boolean autoInstallPeersFromHighestMatch: boolean - allowBuild?: (pkgName: string) => boolean allowedDeprecatedVersions: AllowedDeprecatedVersions allPreferredVersions?: PreferredVersions appliedPatches: Set @@ -1468,7 +1467,6 @@ async function resolveDependency ( // WARN: It is very important to keep this sync // Otherwise, deprecation messages for the same package might get written several times ctx.resolvedPkgsById[pkgResponse.body.id] = getResolvedPackage({ - allowBuild: ctx.allowBuild, dependencyLockfile: currentPkg.dependencyLockfile, pkgIdWithPatchHash, force: ctx.force, @@ -1586,7 +1584,6 @@ function pkgIsLeaf (pkg: PackageManifest): boolean { function getResolvedPackage ( options: { - allowBuild?: (pkgName: string) => boolean dependencyLockfile?: PackageSnapshot pkgIdWithPatchHash: PkgIdWithPatchHash force: boolean diff --git a/pkg-manager/resolve-dependencies/src/resolveDependencyTree.ts b/pkg-manager/resolve-dependencies/src/resolveDependencyTree.ts index 17bb94f142..e9cd58e5d2 100644 --- a/pkg-manager/resolve-dependencies/src/resolveDependencyTree.ts +++ b/pkg-manager/resolve-dependencies/src/resolveDependencyTree.ts @@ -96,7 +96,6 @@ export interface ImporterToResolveGeneric extends Importer< export interface ResolveDependenciesOptions { autoInstallPeers?: boolean autoInstallPeersFromHighestMatch?: boolean - allowBuild?: (pkgName: string) => boolean allowedDeprecatedVersions: AllowedDeprecatedVersions allowNonAppliedPatches: boolean catalogs?: Catalogs @@ -154,7 +153,6 @@ export async function resolveDependencyTree ( const ctx: ResolutionContext = { autoInstallPeers, autoInstallPeersFromHighestMatch: opts.autoInstallPeersFromHighestMatch === true, - allowBuild: opts.allowBuild, allowedDeprecatedVersions: opts.allowedDeprecatedVersions, catalogResolver: resolveFromCatalog.bind(null, opts.catalogs ?? {}), childrenByParentId: {} as ChildrenByParentId,