mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-04-10 18:18:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

perf(pkgs-graph): optimize createPkgGraph by calling Object.values only once (#6281)

Browse Source 
ref #6277
This commit is contained in:
Jake Bailey
2023-03-25 16:02:31 -07:00
committed by GitHub
parent eb5b7d5299
commit 5720681808
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/green-scissors-battle.md Normal file
View File

@@ -0,0 +1,5 @@
---
"@pnpm/workspace.pkgs-graph": patch
---
Optimize createPkgGraph by calling Object.values only once

5
workspace/pkgs-graph/src/index.ts
View File

@@ -35,6 +35,7 @@ export function createPkgGraph<T> (pkgs: Array<Package & T>, opts?: {
unmatched: Array<{ pkgName: string, range: string }>
} {
const pkgMap = createPkgMap(pkgs)
const pkgMapValues = Object.values(pkgMap)
const unmatched: Array<{ pkgName: string, range: string }> = []
const graph = mapValues((pkg) => ({
dependencies: createNode(pkg),
@@ -66,7 +67,7 @@ export function createPkgGraph<T> (pkgs: Array<Package & T>, opts?: {
}
if (spec.type === 'directory') {
const matchedPkg = Object.values(pkgMap).find(pkg => path.relative(pkg.dir, spec.fetchSpec) === '')
const matchedPkg = pkgMapValues.find(pkg => path.relative(pkg.dir, spec.fetchSpec) === '')
if (matchedPkg == null) {
return ''
}
@@ -75,7 +76,7 @@ export function createPkgGraph<T> (pkgs: Array<Package & T>, opts?: {
if (spec.type !== 'version' && spec.type !== 'range') return ''
const pkgs = Object.values(pkgMap).filter(pkg => pkg.manifest.name === depName)
const pkgs = pkgMapValues.filter(pkg => pkg.manifest.name === depName)
if (pkgs.length === 0) return ''
const versions = pkgs.filter(({ manifest }) => manifest.version)
.map(pkg => pkg.manifest.version) as string[]