mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-07-02 03:45:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

test(graph-hasher): make node a hard prerequisite for detect tests

Browse Source 
The two `detect_node_*` tests previously skipped silently when `node`
was missing from `PATH`. `node` is a documented prerequisite of the
test suite (see `pacquet/CONTRIBUTING.md`'s setup section), so a
missing binary is a test-env bug to surface, not a condition to paper
over. Switch the `let Some(...) = ... else { return }` skips to
`expect` so a missing `node` fails loudly with a clear message.

https://claude.ai/code/session_01D8WBTfQzTpsZsRknrzwNKL
This commit is contained in:
Claude
2026-05-18 03:04:50 +00:00
parent c3ca5cda13
commit 5d0987c433
1 changed files with 7 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
pacquet/crates/graph-hasher/src/engine_name.rs
View File

@@ -238,15 +238,12 @@ mod tests {
}
/// `detect_node_version` returns the full version string with
/// the leading `v` stripped when `node --version` is reachable.
/// Skips silently when there is no `node` on `PATH` (we can't
/// assert presence in every test runner).
/// the leading `v` stripped. `node` is a hard prerequisite for
/// the test suite — if it isn't on `PATH` that's a test-env
/// bug, so we `expect` rather than skip.
#[test]
fn detect_node_version_strips_leading_v_when_node_is_available() {
let Some(version) = detect_node_version() else {
eprintln!("`node` not on PATH; skipping version-detect test");
return;
};
fn detect_node_version_strips_leading_v() {
let version = detect_node_version().expect("`node` must be on PATH for the test suite");
assert!(!version.starts_with('v'), "leading `v` must be stripped: {version:?}");
let major = version.split('.').next().expect("at least one component");
assert!(major.parse::<u32>().is_ok(), "major must be numeric: {version:?}");
@@ -257,10 +254,8 @@ mod tests {
/// matches the leading component of the full version string.
#[test]
fn detect_node_major_matches_detect_node_version_leading_component() {
let (Some(major), Some(version)) = (detect_node_major(), detect_node_version()) else {
eprintln!("`node` not on PATH; skipping version-detect test");
return;
};
let major = detect_node_major().expect("`node` must be on PATH for the test suite");
let version = detect_node_version().expect("`node` must be on PATH for the test suite");
let leading: u32 =
version.split('.').next().expect("non-empty version").parse().expect("major numeric");
assert_eq!(major, leading);