From 69a675f4164cb0989a7dac28c032b4983b35506a Mon Sep 17 00:00:00 2001 From: Zoltan Kochan Date: Wed, 12 Aug 2020 11:31:51 +0300 Subject: [PATCH] fix(publish): don't use pnpm-temp dist tag close ##2686 PR #2767 --- .changeset/funny-goats-march.md | 5 +++++ .../src/recursivePublish.ts | 14 ++------------ 2 files changed, 7 insertions(+), 12 deletions(-) create mode 100644 .changeset/funny-goats-march.md diff --git a/.changeset/funny-goats-march.md b/.changeset/funny-goats-march.md new file mode 100644 index 0000000000..509a99283f --- /dev/null +++ b/.changeset/funny-goats-march.md @@ -0,0 +1,5 @@ +--- +"@pnpm/plugin-commands-publishing": patch +--- + +`pnpm publish -r` should not publish packages with `pnpm-temp` distribution tag. diff --git a/packages/plugin-commands-publishing/src/recursivePublish.ts b/packages/plugin-commands-publishing/src/recursivePublish.ts index d7aa03e987..f3f7eea9e6 100644 --- a/packages/plugin-commands-publishing/src/recursivePublish.ts +++ b/packages/plugin-commands-publishing/src/recursivePublish.ts @@ -82,6 +82,7 @@ export default async function ( appendedArgs.push('--dry-run') } const chunks = sortPackages(opts.selectedProjectsGraph) + const tag = opts.tag ?? 'latest' for (const chunk of chunks) { for (const pkgDir of chunk) { if (!publishedPkgDirs.has(pkgDir)) continue @@ -93,7 +94,7 @@ export default async function ( 'publish', pkg.dir, '--tag', - 'pnpm-temp', + tag, '--registry', pickRegistryForPackage(opts.registries, pkg.manifest.name!), ...appendedArgs, @@ -104,17 +105,6 @@ export default async function ( }, [pkg.dir]) } } - const tag = opts.tag || 'latest' - for (const pkg of pkgsToPublish) { - runNpm(opts.npmPath, [ - 'dist-tag', - 'add', - `${pkg.manifest.name}@${pkg.manifest.version}`, - tag, - '--registry', - pickRegistryForPackage(opts.registries, pkg.manifest.name!), - ]) - } } async function isAlreadyPublished (