From 6b2abc89d4b4c5121fc3700e9dd376fa198ce1eb Mon Sep 17 00:00:00 2001 From: Zoltan Kochan Date: Thu, 12 Apr 2018 02:38:58 +0300 Subject: [PATCH] fix: nameVerFromPkgSnapshot() always returns name and version --- package.json | 2 +- shrinkwrap.yaml | 2 +- src/nameVerFromPkgSnapshot.ts | 6 ++---- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 6b1a1fc6c8..d5127ad89f 100644 --- a/package.json +++ b/package.json @@ -54,7 +54,7 @@ "@types/js-yaml": "^3.10.1", "@types/node": "^9.3.0", "@types/ramda": "^0.25.12", - "dependency-path": "^1.0.0", + "dependency-path": "^1.2.1", "get-npm-tarball-url": "^2.0.1", "js-yaml": "^3.8.4", "load-yaml-file": "^0.1.0", diff --git a/shrinkwrap.yaml b/shrinkwrap.yaml index 6e57b71c22..9ceb1bc827 100644 --- a/shrinkwrap.yaml +++ b/shrinkwrap.yaml @@ -1506,7 +1506,7 @@ specifiers: '@types/node': ^9.3.0 '@types/ramda': ^0.25.12 '@types/tape': ^4.2.30 - dependency-path: ^1.0.0 + dependency-path: ^1.2.1 get-npm-tarball-url: ^2.0.1 js-yaml: ^3.8.4 load-yaml-file: ^0.1.0 diff --git a/src/nameVerFromPkgSnapshot.ts b/src/nameVerFromPkgSnapshot.ts index 8425e3c036..f22b83b312 100644 --- a/src/nameVerFromPkgSnapshot.ts +++ b/src/nameVerFromPkgSnapshot.ts @@ -8,10 +8,8 @@ export default ( if (!pkgSnapshot.name) { const pkgInfo = dp.parse(relDepPath) return { - // tslint:disable:no-string-literal - name: pkgInfo['name'], - version: pkgInfo['version'], - // tslint:enable:no-string-literal + name: pkgInfo.name as string, + version: pkgInfo.version as string, } } return {