From 732430a1f32a4f2fa0f46c9c75b820ea96b17c1a Mon Sep 17 00:00:00 2001 From: Zoltan Kochan Date: Sun, 28 Jan 2024 12:25:20 +0100 Subject: [PATCH] fix: don't add bundleDependencies=false to the lockfile (#7580) close #7576 --- .changeset/tall-bears-tan.md | 6 ++++++ .../resolve-dependencies/src/updateLockfile.ts | 13 ++++++++++--- 2 files changed, 16 insertions(+), 3 deletions(-) create mode 100644 .changeset/tall-bears-tan.md diff --git a/.changeset/tall-bears-tan.md b/.changeset/tall-bears-tan.md new file mode 100644 index 0000000000..977390ac10 --- /dev/null +++ b/.changeset/tall-bears-tan.md @@ -0,0 +1,6 @@ +--- +"@pnpm/resolve-dependencies": patch +"pnpm": patch +--- + +`bundledDependencies` should never be added to the lockfile with `false` as the value [#7576](https://github.com/pnpm/pnpm/issues/7576). diff --git a/pkg-manager/resolve-dependencies/src/updateLockfile.ts b/pkg-manager/resolve-dependencies/src/updateLockfile.ts index f33e1be5d4..980ff30cd2 100644 --- a/pkg-manager/resolve-dependencies/src/updateLockfile.ts +++ b/pkg-manager/resolve-dependencies/src/updateLockfile.ts @@ -150,9 +150,16 @@ function toLockfileDependency ( if (pkg.additionalInfo.libc != null) { result['libc'] = pkg.additionalInfo.libc } - if (Array.isArray(pkg.additionalInfo.bundledDependencies) || Array.isArray(pkg.additionalInfo.bundleDependencies) || - typeof pkg.additionalInfo.bundledDependencies === 'boolean' || typeof pkg.additionalInfo.bundleDependencies === 'boolean') { - result['bundledDependencies'] = pkg.additionalInfo.bundledDependencies ?? pkg.additionalInfo.bundleDependencies + if ( + Array.isArray(pkg.additionalInfo.bundledDependencies) || + pkg.additionalInfo.bundledDependencies === true + ) { + result['bundledDependencies'] = pkg.additionalInfo.bundledDependencies + } else if ( + Array.isArray(pkg.additionalInfo.bundleDependencies) || + pkg.additionalInfo.bundleDependencies === true + ) { + result['bundledDependencies'] = pkg.additionalInfo.bundleDependencies } if (pkg.additionalInfo.deprecated) { result['deprecated'] = pkg.additionalInfo.deprecated