fix: do not run node-gyp rebuild if preinstall lifecycle script is present (#7206)

.changeset/swift-ducks-talk.md

@@ -0,0 +1,6 @@
+---
+"@pnpm/lifecycle": patch
+"pnpm": patch
+---
+
+Do not run node-gyp rebuild if `preinstall` lifecycle script is present [#7206](https://github.com/pnpm/pnpm/pull/7206).

exec/lifecycle/src/index.ts

@@ -27,7 +27,7 @@ export async function runPostinstallHooks (
     pkg.scripts = {}
   }
 
-  if (!pkg.scripts.install) {
+  if (!pkg.scripts.install && !pkg.scripts.preinstall) {
     await checkBindingGyp(opts.pkgRoot, pkg.scripts)
   }
 
@@ -47,8 +47,8 @@ export async function runPostinstallHooks (
 }
 
 /**
- * Run node-gyp when binding.gyp is available. Only do this when there's no
- * `install` script (see `npm help scripts`).
+ * Run node-gyp when binding.gyp is available. Only do this when there are no
+ * `install` and `preinstall` scripts (see `npm help scripts`).
  */
 async function checkBindingGyp (
   root: string,

exec/lifecycle/test/fixtures/gyp-with-preinstall/binding.gyp

@@ -0,0 +1,8 @@
+{
+  "targets": [
+    {
+      "target_name": "binding",
+      "sources": [ "binding.cc" ]
+    }
+  ]
+}

exec/lifecycle/test/fixtures/gyp-with-preinstall/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "gyp-with-preinstall",
+  "version": "1.0.0",
+  "scripts": {
+    "preinstall": "node -e \"process.stdout.write('preinstall')\" | json-append output.json"
+  }
+}

exec/lifecycle/test/index.ts

@@ -84,3 +84,18 @@ test('runLifecycleHook() should throw an error while missing script start or fil
     })
   ).rejects.toThrow(new PnpmError('NO_SCRIPT_OR_SERVER', 'Missing script start or file server.js'))
 })
+
+test('preinstall script does not trigger node-gyp rebuild', async () => {
+  const pkgRoot = f.find('gyp-with-preinstall')
+  await rimraf(path.join(pkgRoot, 'output.json'))
+  await runPostinstallHooks({
+    depPath: '/gyp-with-preinstall/1.0.0',
+    optional: false,
+    pkgRoot,
+    rawConfig: {},
+    rootModulesDir,
+    unsafePerm: true,
+  })
+
+  expect(loadJsonFile.sync(path.join(pkgRoot, 'output.json'))).toStrictEqual(['preinstall'])
+})