From 86af5326ffc0ba44e79fc113f34c04608aea2e2d Mon Sep 17 00:00:00 2001 From: Zoltan Kochan Date: Thu, 21 May 2026 22:12:34 +0200 Subject: [PATCH] ci(pacquet): scope the e2e run to the pnpm package only Now that --no-runtime fixed the VM-modules loader, tests actually run. The next failure mode was real: other workspace packages (e.g. @pnpm/building.commands) shell out to pnpm in their tests, and PNPM_E2E_BIN routes those calls through pacquet, which doesn't implement every command they exercise. Add a dedicated test-pkgs-pnpm script so the e2e job runs jest only in the pnpm package and PNPM_E2E_BIN affects nothing else. Written by an agent (Claude Code, claude-opus-4-7). --- .github/workflows/pacquet-ci.yml | 12 +++++++----- package.json | 1 + 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pacquet-ci.yml b/.github/workflows/pacquet-ci.yml index 119a2384e9..c8a9e9db0b 100644 --- a/.github/workflows/pacquet-ci.yml +++ b/.github/workflows/pacquet-ci.yml @@ -176,11 +176,13 @@ jobs: # auto-reinstalls before every script and seems to break jest's # VM-modules loader. test.yml disables it for the same reason. pnpm_config_verify_deps_before_run: false - # `pn run test-pkgs-all` matches the call shape test.yml uses (via - # `ci:test-all`): the hidden `.test` invocation lives inside a - # script-to-script chain, which is the only way pnpm allows it. - # Calling `pn -r .test` directly trips ERR_PNPM_HIDDEN_SCRIPT. - run: pnpm run test-pkgs-all + # Use the dedicated `test-pkgs-pnpm` script so PNPM_E2E_BIN only + # affects the pnpm package's e2e suite — running every package's + # `.test` would route their pnpm-driven assertions through pacquet + # too, which fails for commands pacquet doesn't implement. + # Going through a package.json script also keeps the hidden `.test` + # invocation inside a script chain (required by pnpm). + run: pnpm run test-pkgs-pnpm doc: name: Doc diff --git a/package.json b/package.json index 2166f1cd1a..7d712991ed 100644 --- a/package.json +++ b/package.json @@ -14,6 +14,7 @@ "ci:test-all": "pn prepare-fixtures && pn test-pkgs-all", "remove-temp-dir": "shx rm -rf ../pnpm_tmp", "test-pkgs-all": "pn remove-temp-dir && pn --no-sort --workspace-concurrency=1 -r .test", + "test-pkgs-pnpm": "pn remove-temp-dir && pn --filter=pnpm --workspace-concurrency=1 -r .test", "test-branch": "pn pretest && pn lint && git remote set-branches --add origin main && git fetch origin main && pn test-pkgs-branch", "ci:test-branch": "pn prepare-fixtures && pn test-pkgs-branch", "test-pkgs-branch": "pn remove-temp-dir && pn --workspace-concurrency=1 --filter=...[origin/main] --no-sort --if-present .test",