mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-04-10 18:18:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): don't fail on skipped optional deps, when calculating depsRequiringBuild (#8390)

Browse Source
This commit is contained in:
Zoltan Kochan
2024-08-08 14:04:47 +02:00
committed by GitHub
parent 449041c5aa
commit 8e055d2f05
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/seven-chairs-hammer.md Normal file
View File

@@ -0,0 +1,5 @@
---
"@pnpm/core": patch
---
Don't fail on skipped optional dependencies, when searching for dependencies that should be built.

5
pkg-manager/core/src/install/index.ts
View File

@@ -1419,8 +1419,9 @@ const _installInContext: InstallFunction = async (projects, ctx, opts) => {
await waitTillAllFetchingsFinish()
const depsRequiringBuild: DepPath[] = []
if (opts.returnListOfDepsRequiringBuild) {
await Promise.all(Object.entries(dependenciesGraph).map(async ([depPath, { fetching }]) => {
const { files } = await fetching()
await Promise.all(Object.entries(dependenciesGraph).map(async ([depPath, node]) => {
if (node == null) return // We cannot detect if a skipped optional dependency requires build
const { files } = await node.fetching()
if (files.requiresBuild) {
depsRequiringBuild.push(depPath as DepPath)
}