mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-03-23 17:41:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: escape a colon in tarbal dependency ID (#3183)

Browse Source 
close #3182
This commit is contained in:
Zoltan Kochan
2021-02-22 11:21:27 +02:00
committed by Zoltan Kochan
parent 08039f3870
commit 992820161c
3 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/unlucky-sheep-play.md Normal file
View File

@@ -0,0 +1,5 @@
---
"@pnpm/tarball-resolver": patch
---
The ID of a tarball dependency should not contain colons, when the URL has a port. The colon should be escaped with a plus sign.

2
packages/tarball-resolver/src/index.ts
View File

@@ -10,7 +10,7 @@ export default async function resolveTarball (
if (isRepository(wantedDependency.pref)) return null
return {
id: `@${wantedDependency.pref.replace(/^.*:\/\/(git@)?/, '')}`,
id: `@${wantedDependency.pref.replace(/^.*:\/\/(git@)?/, '').replace(':', '+')}`,
normalizedPref: wantedDependency.pref,
resolution: {
tarball: wantedDependency.pref,

13
packages/tarball-resolver/test/index.ts
View File

@@ -14,6 +14,19 @@ test('tarball from npm registry', async () => {
})
})
test('tarball from URL that contain port number', async () => {
const resolutionResult = await resolveFromTarball({ pref: 'http://buildserver.mycompany.com:81/my-private-package-0.1.6.tgz' })
expect(resolutionResult).toStrictEqual({
id: '@buildserver.mycompany.com+81/my-private-package-0.1.6.tgz',
normalizedPref: 'http://buildserver.mycompany.com:81/my-private-package-0.1.6.tgz',
resolution: {
tarball: 'http://buildserver.mycompany.com:81/my-private-package-0.1.6.tgz',
},
resolvedVia: 'url',
})
})
test('tarball not from npm registry', async () => {
const resolutionResult = await resolveFromTarball({ pref: 'https://github.com/hegemonic/taffydb/tarball/master' })