mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2025-12-23 23:29:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(default-reporter): should print error summary as expected (#6345)

Browse Source 
* fix(default-reporter): should print error summary as expected

* docs: add changeset
This commit is contained in:
await-ovo
2023-04-03 21:33:46 +08:00
committed by GitHub
parent 9c597019b9
commit af3e5559d3
4 changed files with 44 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.changeset/red-knives-decide.md Normal file
View File

@@ -0,0 +1,6 @@
---
"@pnpm/default-reporter": patch
"pnpm": patch
---
Should report error summary as expected.

8
cli/default-reporter/src/reportError.ts
View File

@@ -258,10 +258,10 @@ function reportLockfileBreakingChange (err: Error, msg: object) {
}
}
function formatRecursiveCommandSummary (msg: { fails: Array<Error & { prefix: string }>, passes: number }) {
const output = EOL + `Summary: ${chalk.red(`${msg.fails.length} fails`)}, ${msg.passes} passes` + EOL + EOL +
msg.fails.map((fail) => {
return fail.prefix + ':' + EOL + formatErrorSummary(fail.message)
function formatRecursiveCommandSummary (msg: { failures: Array<Error & { prefix: string }>, passes: number }) {
const output = EOL + `Summary: ${chalk.red(`${msg.failures.length} fails`)}, ${msg.passes} passes` + EOL + EOL +
msg.failures.map(({ message, prefix }) => {
return prefix + ':' + EOL + formatErrorSummary(message)
}).join(EOL + EOL)
return {
title: '',

2
cli/default-reporter/test/index.ts
View File

@@ -572,7 +572,7 @@ ${formatError('ERROR', 'f failed')}`)
})
const err = new PnpmError('RECURSIVE_FAIL', '...')
err['fails'] = [
err['failures'] = [
{
message: 'a failed',
prefix: '/a',

33
pnpm/test/errorHandler.test.ts
View File

@@ -47,3 +47,36 @@ test('should clean up child processes when process exited', async () => {
expect(await isPortInUse(9990)).toBe(false)
expect(await isPortInUse(9999)).toBe(false)
})
test('should print error summary when some packages fail with --no-bail', async () => {
preparePackages([
{
location: 'project-1',
package: {
scripts: {
build: 'echo "build project-1"',
},
},
},
{
name: 'project-2',
version: '1.0.0',
scripts: {
build: 'exit 1',
},
},
{
name: 'project-3',
version: '1.0.0',
scripts: {
build: 'echo "build project-3"',
},
},
])
await writeYamlFile('pnpm-workspace.yaml', { packages: ['**', '!store/**'] })
const { stdout } = execPnpmSync(['-r', '--no-bail', 'run', 'build'])
const output = stdout.toString()
expect(output).toContain('ERR_PNPM_RECURSIVE_FAIL')
expect(output).toContain('Summary: 1 fails, 2 passes')
expect(output).toContain('ERROR  project-2@1.0.0 build: `exit 1`')
})