From afb7ea11604f597c128337a57d596dc8f5dcdfbb Mon Sep 17 00:00:00 2001 From: Zoltan Kochan Date: Sun, 3 Jun 2018 02:27:07 +0300 Subject: [PATCH] fix(reporter): use bright cyan instead of blue blue is hard to read in many consoles --- packages/default-reporter/README.md | 4 ++++ packages/default-reporter/src/reporterForClient.ts | 4 ++-- packages/default-reporter/test/index.ts | 4 ++-- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/default-reporter/README.md b/packages/default-reporter/README.md index af193bb29a..1e1a26a847 100644 --- a/packages/default-reporter/README.md +++ b/packages/default-reporter/README.md @@ -8,6 +8,10 @@ npm install pnpm-default-reporter ``` +## Style Guide + +1. Never use blue as font color as it is hard to read in many consoles + ## License [MIT](LICENSE) diff --git a/packages/default-reporter/src/reporterForClient.ts b/packages/default-reporter/src/reporterForClient.ts index 03af0a1aa8..3b03e7e299 100644 --- a/packages/default-reporter/src/reporterForClient.ts +++ b/packages/default-reporter/src/reporterForClient.ts @@ -35,7 +35,7 @@ const REMOVED_CHAR = chalk.red('-') const LINKED_CHAR = chalk.magentaBright('#') const PREFIX_MAX_LENGTH = 40 -const hlValue = chalk.blue +const hlValue = chalk.cyanBright const hlPkgId = chalk['whiteBright'] export default function ( @@ -231,7 +231,7 @@ export default function ( const diffs = R.values(pkgsDiff[depType]) if (diffs.length) { msg += EOL - msg += chalk.blue(`${propertyByDependencyType[depType]}:`) + msg += chalk.cyanBright(`${propertyByDependencyType[depType]}:`) msg += EOL msg += printDiffs(diffs) msg += EOL diff --git a/packages/default-reporter/test/index.ts b/packages/default-reporter/test/index.ts index 9d939f1adc..5cc6e848fa 100644 --- a/packages/default-reporter/test/index.ts +++ b/packages/default-reporter/test/index.ts @@ -18,8 +18,8 @@ const versionColor = chalk.grey const ADD = chalk.green('+') const SUB = chalk.red('-') const LINKED = chalk.magentaBright('#') -const h1 = chalk.blue -const hlValue = chalk.blue +const h1 = chalk.cyanBright +const hlValue = chalk.cyanBright const hlPkgId = chalk['whiteBright'] const POSTINSTALL = hlValue('postinstall') const PREINSTALL = hlValue(' preinstall')