mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-07-26 07:27:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

feat: show path info for pnpm why --json or --long (#6109)

Browse Source 
close #6103
This commit is contained in:
await-ovo
2023-02-20 11:41:57 +08:00
committed by GitHub
parent 1b2e09ccfd
commit b9ab2e0bf2
5 changed files with 30 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.changeset/little-donuts-suffer.md Normal file
View File

@@ -0,0 +1,6 @@
---
"@pnpm/list": minor
"pnpm": minor
---
Show path info for `pnpm why --json` or `--long` [#6103](https://github.com/pnpm/pnpm/issues/6103).

3
reviewing/list/src/getPkgInfo.ts
View File

@@ -10,7 +10,7 @@ interface PkgData {
resolved?: string
}
export type PkgInfo = Omit<PkgData, 'name' | 'path'> & Pick<ProjectManifest, 'description' | 'license' | 'author' | 'homepage'> & {
export type PkgInfo = Omit<PkgData, 'name'> & Pick<ProjectManifest, 'description' | 'license' | 'author' | 'homepage'> & {
from: string
repository?: string
}
@@ -41,5 +41,6 @@ export async function getPkgInfo (pkg: PkgData): Promise<PkgInfo> {
repository: (manifest.repository && (
typeof manifest.repository === 'string' ? manifest.repository : manifest.repository.url
)) ?? undefined,
path: pkg.path,
}
}

2
reviewing/list/src/renderJson.ts
View File

@@ -60,8 +60,8 @@ export async function toJsonResult (
alias: node.alias as string | undefined,
from: node.name,
version: node.version,
resolved: node.resolved,
path: node.path,
}
if (Object.keys(subDependencies).length > 0) {
dep.dependencies = subDependencies

4
reviewing/list/src/renderTree.ts
View File

@@ -123,6 +123,10 @@ export async function toArchyTree (
if (pkg.homepage) {
labelLines.push(pkg.homepage)
}
if (pkg.path) {
labelLines.push(pkg.path)
}
return {
label: labelLines.join('\n'),
nodes,

18
reviewing/list/test/index.ts
View File

@@ -235,18 +235,21 @@ write-json-file ${VERSION_CLR('2.3.0')}
Stringify and write JSON to a file atomically
git+https://github.com/sindresorhus/write-json-file.git
https://github.com/sindresorhus/write-json-file#readme
${path.join(fixture, 'node_modules/.pnpm/write-json-file@2.3.0/node_modules/write-json-file')}
${DEV_DEPENDENCIES}
${DEV_DEP_ONLY_CLR('is-positive')} ${VERSION_CLR('3.1.0')}
Check if something is a positive number
git+https://github.com/kevva/is-positive.git
https://github.com/kevva/is-positive#readme
${path.join(fixture, 'node_modules/.pnpm/is-positive@3.1.0/node_modules/is-positive')}
${OPTIONAL_DEPENDENCIES}
${OPTIONAL_DEP_CLR('is-negative')} ${VERSION_CLR('2.1.0')}
Check if something is a negative number
git+https://github.com/kevva/is-negative.git
https://github.com/kevva/is-negative#readme`)
https://github.com/kevva/is-negative#readme
${path.join(fixture, 'node_modules/.pnpm/is-negative@2.1.0/node_modules/is-negative')}`)
})
test('parseable list in workspace with private package', async () => {
@@ -295,6 +298,7 @@ test('JSON list in workspace with private package', async () => {
from: 'is-positive',
version: '1.0.0',
resolved: 'https://registry.npmjs.org/is-positive/-/is-positive-1.0.0.tgz',
path: path.join(workspaceWithPrivatePkgs, 'node_modules/.pnpm/is-positive@1.0.0/node_modules/is-positive'),
},
},
},
@@ -308,6 +312,7 @@ test('JSON list in workspace with private package', async () => {
from: 'is-positive',
version: '1.0.0',
resolved: 'https://registry.npmjs.org/is-positive/-/is-positive-1.0.0.tgz',
path: path.join(workspaceWithPrivatePkgs, 'node_modules/.pnpm/is-positive@1.0.0/node_modules/is-positive'),
},
},
},
@@ -340,6 +345,7 @@ test('JSON list with depth 1', async () => {
version: '2.3.0',
resolved: 'https://registry.npmjs.org/write-json-file/-/write-json-file-2.3.0.tgz',
path: path.join(fixture, 'node_modules/.pnpm/write-json-file@2.3.0/node_modules/write-json-file'),
dependencies: {
'detect-indent': {
@@ -347,36 +353,42 @@ test('JSON list with depth 1', async () => {
version: '5.0.0',
resolved: 'https://registry.npmjs.org/detect-indent/-/detect-indent-5.0.0.tgz',
path: path.join(fixture, 'node_modules/.pnpm/detect-indent@5.0.0/node_modules/detect-indent'),
},
'graceful-fs': {
from: 'graceful-fs',
version: '4.2.2',
resolved: 'https://registry.npmjs.org/graceful-fs/-/graceful-fs-4.2.2.tgz',
path: path.join(fixture, 'node_modules/.pnpm/graceful-fs@4.2.2/node_modules/graceful-fs'),
},
'make-dir': {
from: 'make-dir',
version: '1.3.0',
resolved: 'https://registry.npmjs.org/make-dir/-/make-dir-1.3.0.tgz',
path: path.join(fixture, 'node_modules/.pnpm/make-dir@1.3.0/node_modules/make-dir'),
},
pify: {
from: 'pify',
version: '3.0.0',
resolved: 'https://registry.npmjs.org/pify/-/pify-3.0.0.tgz',
path: path.join(fixture, 'node_modules/.pnpm/pify@3.0.0/node_modules/pify'),
},
'sort-keys': {
from: 'sort-keys',
version: '2.0.0',
resolved: 'https://registry.npmjs.org/sort-keys/-/sort-keys-2.0.0.tgz',
path: path.join(fixture, 'node_modules/.pnpm/sort-keys@2.0.0/node_modules/sort-keys'),
},
'write-file-atomic': {
from: 'write-file-atomic',
version: '2.4.3',
resolved: 'https://registry.npmjs.org/write-file-atomic/-/write-file-atomic-2.4.3.tgz',
path: path.join(fixture, 'node_modules/.pnpm/write-file-atomic@2.4.3/node_modules/write-file-atomic'),
},
},
},
@@ -387,6 +399,7 @@ test('JSON list with depth 1', async () => {
version: '3.1.0',
resolved: 'https://registry.npmjs.org/is-positive/-/is-positive-3.1.0.tgz',
path: path.join(fixture, 'node_modules/.pnpm/is-positive@3.1.0/node_modules/is-positive'),
},
},
optionalDependencies: {
@@ -395,6 +408,7 @@ test('JSON list with depth 1', async () => {
version: '2.1.0',
resolved: 'https://registry.npmjs.org/is-negative/-/is-negative-2.1.0.tgz',
path: path.join(fixture, 'node_modules/.pnpm/is-negative@2.1.0/node_modules/is-negative'),
},
},
}], null, 2))
@@ -415,6 +429,7 @@ test('JSON list with aliased dep', async () => {
from: 'is-positive',
version: '1.0.0',
resolved: 'https://registry.npmjs.org/is-positive/-/is-positive-1.0.0.tgz',
path: path.join(fixtureWithAliasedDep, 'node_modules/.pnpm/is-positive@1.0.0/node_modules/is-positive'),
},
},
},
@@ -444,6 +459,7 @@ test('JSON list with aliased dep', async () => {
},
homepage: 'https://github.com/kevva/is-positive#readme',
repository: 'git+https://github.com/kevva/is-positive.git',
path: path.join(fixtureWithAliasedDep, 'node_modules/.pnpm/is-positive@1.0.0/node_modules/is-positive'),
},
},
}], null, 2)