fix: ETXTBSY error on running setup (#8780)

close #8173

.changeset/friendly-ravens-collect.md

@@ -0,0 +1,6 @@
+---
+"@pnpm/plugin-commands-setup": patch
+"pnpm": patch
+---
+
+`pnpm setup` should remove the CLI from the target location before moving the new binary [#8173](https://github.com/pnpm/pnpm/issues/8173).

packages/plugin-commands-setup/package.json

@@ -33,6 +33,7 @@
     "@pnpm/cli-meta": "workspace:*",
     "@pnpm/cli-utils": "workspace:*",
     "@pnpm/os.env.path-extender": "catalog:",
+    "@zkochan/rimraf": "catalog:",
     "render-help": "catalog:"
   },
   "funding": "https://opencollective.com/pnpm",

packages/plugin-commands-setup/src/setup.ts

@@ -9,6 +9,7 @@ import {
   type PathExtenderReport,
 } from '@pnpm/os.env.path-extender'
 import renderHelp from 'render-help'
+import rimraf from '@zkochan/rimraf'
 
 export const rcOptionsTypes = (): Record<string, unknown> => ({})
 
@@ -59,6 +60,7 @@ function copyCli (currentLocation: string, targetDir: string): void {
     prefix: process.cwd(),
   })
   fs.mkdirSync(targetDir, { recursive: true })
+  rimraf.sync(newExecPath)
   fs.copyFileSync(currentLocation, newExecPath)
 }
 

pnpm-lock.yaml

@@ -3875,6 +3875,9 @@ importers:
       '@pnpm/os.env.path-extender':
         specifier: 'catalog:'
         version: 2.0.0
+      '@zkochan/rimraf':
+        specifier: 'catalog:'
+        version: 3.0.2
       render-help:
         specifier: 'catalog:'
         version: 1.0.3