mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-04-10 18:18:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: overrides should override dev deps (#3327)

Browse Source
This commit is contained in:
Zoltan Kochan
2021-04-09 11:32:23 +03:00
committed by GitHub
parent 057366e106
commit c70c77f89e
3 changed files with 39 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/wet-pumas-explain.md Normal file
View File

@@ -0,0 +1,5 @@
---
"supi": patch
---
Overrides should override devDependencies as well.

1
packages/supi/src/install/createVersionsOverrider.ts
View File

@@ -54,6 +54,7 @@ interface VersionOverrideWithParent extends VersionOverride {
function overrideDepsOfPkg (pkg: PackageManifest, versionOverrides: VersionOverride[]) {
if (pkg.dependencies != null) overrideDeps(versionOverrides, pkg.dependencies)
if (pkg.optionalDependencies != null) overrideDeps(versionOverrides, pkg.optionalDependencies)
if (pkg.devDependencies != null) overrideDeps(versionOverrides, pkg.devDependencies)
return pkg
}

33
packages/supi/test/createVersionOverrider.test.ts
View File

@@ -31,3 +31,36 @@ test('createVersionsOverrider() overrides dependencies of specified packages onl
},
})
})
test('createVersionsOverrider() overrides all types of dependencies', () => {
const overrider = createVersionOverrider({
foo: '3.0.0',
bar: '3.0.0',
qar: '3.0.0',
})
expect(overrider({
name: 'foo',
version: '1.2.0',
dependencies: {
foo: '^1.2.0',
},
optionalDependencies: {
bar: '^1.2.0',
},
devDependencies: {
qar: '^1.2.0',
},
})).toStrictEqual({
name: 'foo',
version: '1.2.0',
dependencies: {
foo: '3.0.0',
},
optionalDependencies: {
bar: '3.0.0',
},
devDependencies: {
qar: '3.0.0',
},
})
})