refactor: rootProjectManifestDir is a required option

.changeset/kind-toys-prove.md

@@ -0,0 +1,5 @@
+---
+"@pnpm/plugin-commands-installation": patch
+---
+
+`pnpm fetch` read settings from root project manifest.

.changeset/silver-rice-battle.md

@@ -0,0 +1,14 @@
+---
+"@pnpm/plugin-commands-installation": major
+"@pnpm/plugin-commands-script-runners": major
+"@pnpm/plugin-commands-licenses": major
+"@pnpm/plugin-commands-outdated": major
+"@pnpm/plugin-commands-patching": major
+"@pnpm/plugin-commands-listing": major
+"@pnpm/plugin-commands-deploy": major
+"@pnpm/plugin-commands-audit": major
+"@pnpm/plugin-commands-rebuild": major
+"@pnpm/config": minor
+---
+
+`rootProjectManifestDir` is a required field.

config/config/src/Config.ts

@@ -169,7 +169,7 @@ export interface Config {
 
   testPattern?: string[]
   changedFilesIgnorePattern?: string[]
-  rootProjectManifestDir?: string
+  rootProjectManifestDir: string
   rootProjectManifest?: ProjectManifest
   userConfig: Record<string, string>
 }

exec/plugin-commands-rebuild/src/implementation/extendRebuildOptions.ts

@@ -101,7 +101,7 @@ export async function extendRebuildOptions (
     ...defaultOpts,
     ...opts,
     storeDir: defaultOpts.storeDir,
-    ...(opts.rootProjectManifest ? getOptionsFromRootManifest(opts.rootProjectManifestDir!, opts.rootProjectManifest) : {}),
+    ...(opts.rootProjectManifest ? getOptionsFromRootManifest(opts.rootProjectManifestDir, opts.rootProjectManifest) : {}),
   }
   extendedOpts.registries = normalizeRegistries(extendedOpts.registries)
   return extendedOpts

exec/plugin-commands-rebuild/src/rebuild.ts

@@ -79,6 +79,8 @@ export async function handler (
   | 'lockfileDir'
   | 'nodeLinker'
   | 'rawLocalConfig'
+  | 'rootProjectManifest'
+  | 'rootProjectManifestDir'
   | 'registries'
   | 'scriptShell'
   | 'selectedProjectsGraph'

exec/plugin-commands-rebuild/src/recursive.ts

@@ -25,6 +25,8 @@ type RecursiveRebuildOpts = CreateStoreControllerOptions & Pick<Config,
 | 'nodeLinker'
 | 'rawLocalConfig'
 | 'registries'
+| 'rootProjectManifest'
+| 'rootProjectManifestDir'
 | 'sharedWorkspaceLockfile'
 > & {
   pending?: boolean

exec/plugin-commands-rebuild/test/utils/index.ts

@@ -38,6 +38,7 @@ export const DEFAULT_OPTS = {
   rawLocalConfig: {},
   registries: { default: REGISTRY },
   registry: REGISTRY,
+  rootProjectManifestDir: '',
   sort: true,
   storeDir: '../store',
   strictSsl: false,

exec/plugin-commands-script-runners/src/dlx.ts

@@ -90,10 +90,11 @@ export async function handler (
   await add.handler({
     // Ideally the config reader should ignore these settings when the dlx command is executed.
     // This is a temporary solution until "@pnpm/config" is refactored.
-    ...omit(['workspaceDir', 'rootProjectManifest', 'rootProjectManifestDir'], opts),
+    ...omit(['workspaceDir', 'rootProjectManifest'], opts),
     bin: binsDir,
     dir: prefix,
     lockfileDir: prefix,
+    rootProjectManifestDir: prefix, // This property won't be used as rootProjectManifest will be undefined
   }, pkgs)
   const binName = opts.package
     ? command

exec/plugin-commands-script-runners/test/utils/index.ts

@@ -40,6 +40,7 @@ export const DEFAULT_OPTS = {
   proxy: undefined,
   rawConfig: { registry: REGISTRY_URL },
   rawLocalConfig: {},
+  rootProjectManifestDir: '',
   registries: { default: REGISTRY_URL },
   registry: REGISTRY_URL,
   sort: true,
@@ -74,6 +75,7 @@ export const DLX_DEFAULT_OPTS = {
   registries: {
     default: REGISTRY_URL,
   },
+  rootProjectManifestDir: '',
   sort: true,
   storeDir: path.join(tmp, 'store'),
   userConfig: {},

lockfile/plugin-commands-audit/test/index.ts

@@ -50,6 +50,7 @@ export const DEFAULT_OPTS = {
   rawConfig,
   rawLocalConfig: {},
   registries,
+  rootProjectManifestDir: '',
   // registry: REGISTRY,
   sort: true,
   storeDir: '../store',

patching/plugin-commands-patching/test/utils/index.ts

@@ -39,6 +39,7 @@ export const DEFAULT_OPTS = {
   rawLocalConfig: {},
   registries: { default: REGISTRY },
   registry: REGISTRY,
+  rootProjectManifestDir: '',
   sort: true,
   storeDir: '../store',
   strictSsl: false,

pkg-manager/plugin-commands-installation/src/fetch.ts

@@ -1,6 +1,6 @@
 import { docsUrl } from '@pnpm/cli-utils'
 import { UNIVERSAL_OPTIONS } from '@pnpm/common-cli-options-help'
-import { type Config } from '@pnpm/config'
+import { type Config, getOptionsFromRootManifest } from '@pnpm/config'
 import { createOrConnectStoreController, type CreateStoreControllerOptions } from '@pnpm/store-connection-manager'
 import { type InstallOptions, mutateModulesInSingleProject } from '@pnpm/core'
 import renderHelp from 'render-help'
@@ -45,7 +45,7 @@ export function help () {
 }
 
 export async function handler (
-  opts: Pick<Config, 'production' | 'dev'> & CreateStoreControllerOptions
+  opts: Pick<Config, 'production' | 'dev' | 'rootProjectManifest' | 'rootProjectManifestDir'> & CreateStoreControllerOptions
 ) {
   const store = await createOrConnectStoreController(opts)
   const include = {
@@ -61,6 +61,7 @@ export async function handler (
     rootDir: process.cwd(),
   }, {
     ...opts,
+    ...getOptionsFromRootManifest(opts.rootProjectManifestDir, opts.rootProjectManifest ?? {}),
     ignorePackageManifest: true,
     include,
     modulesCacheMaxAge: 0,

pkg-manager/plugin-commands-installation/src/install.ts

@@ -271,6 +271,7 @@ export type InstallCommandOptions = Pick<Config,
 | 'production'
 | 'registries'
 | 'rootProjectManifest'
+| 'rootProjectManifestDir'
 | 'save'
 | 'saveDev'
 | 'saveExact'

pkg-manager/plugin-commands-installation/test/add.ts

@@ -32,6 +32,7 @@ const DEFAULT_OPTIONS = {
   registries: {
     default: REGISTRY_URL,
   },
+  rootProjectManifestDir: '',
   sort: true,
   storeDir: path.join(tmp, 'store'),
   userConfig: {},

pkg-manager/plugin-commands-installation/test/fetch.ts

@@ -28,6 +28,7 @@ const DEFAULT_OPTIONS = {
   registries: {
     default: REGISTRY_URL,
   },
+  rootProjectManifestDir: '',
   sort: true,
   userConfig: {},
   workspaceConcurrency: 1,

pkg-manager/plugin-commands-installation/test/global.ts

@@ -31,6 +31,7 @@ const DEFAULT_OPTIONS = {
   registries: {
     default: REGISTRY_URL,
   },
+  rootProjectManifestDir: '',
   sort: true,
   storeDir: path.join(tmp, 'store'),
   userConfig: {},

pkg-manager/plugin-commands-installation/test/import.ts

@@ -33,6 +33,7 @@ const DEFAULT_OPTS = {
   rawConfig: { registry: REGISTRY },
   registries: { default: REGISTRY },
   registry: REGISTRY,
+  rootProjectManifestDir: '',
   storeDir: path.join(TMP, 'store'),
   strictSsl: false,
   userAgent: 'pnpm',

pkg-manager/plugin-commands-installation/test/importRecursive.ts

@@ -31,6 +31,7 @@ const DEFAULT_OPTS = {
   rawConfig: { registry: REGISTRY },
   registries: { default: REGISTRY },
   registry: REGISTRY,
+  rootProjectManifestDir: '',
   storeDir: path.join(TMP, 'store'),
   strictSsl: false,
   userAgent: 'pnpm',

pkg-manager/plugin-commands-installation/test/peerDependencies.ts

@@ -30,6 +30,7 @@ const DEFAULT_OPTIONS = {
   registries: {
     default: REGISTRY_URL,
   },
+  rootProjectManifestDir: '',
   sort: true,
   storeDir: path.join(TMP, 'store'),
   userConfig: {},

pkg-manager/plugin-commands-installation/test/prune.ts

@@ -30,6 +30,7 @@ const DEFAULT_OPTIONS = {
   registries: {
     default: REGISTRY_URL,
   },
+  rootProjectManifestDir: '',
   sort: true,
   userConfig: {},
   workspaceConcurrency: 1,

pkg-manager/plugin-commands-installation/test/update/interactive.ts

@@ -37,6 +37,7 @@ const DEFAULT_OPTIONS = {
   registries: {
     default: REGISTRY_URL,
   },
+  rootProjectManifestDir: '',
   sort: true,
   userConfig: {},
   workspaceConcurrency: 1,

pkg-manager/plugin-commands-installation/test/utils/index.ts

@@ -40,6 +40,7 @@ export const DEFAULT_OPTS = {
   rawLocalConfig: {},
   registries: { default: REGISTRY },
   registry: REGISTRY,
+  rootProjectManifestDir: '',
   sort: true,
   storeDir: '../store',
   strictSsl: false,

releasing/plugin-commands-deploy/test/utils/index.ts

@@ -40,6 +40,7 @@ export const DEFAULT_OPTS = {
   rawLocalConfig: {},
   registries: { default: REGISTRY },
   registry: REGISTRY,
+  rootProjectManifestDir: '',
   sort: true,
   storeDir: '../store',
   strictSsl: false,

reviewing/plugin-commands-licenses/src/licensesList.ts

@@ -25,6 +25,8 @@ Config,
 | 'modulesDir'
 | 'pnpmHomeDir'
 | 'selectedProjectsGraph'
+| 'rootProjectManifest'
+| 'rootProjectManifestDir'
 > &
 Partial<Pick<Config, 'userConfig'>>
 

reviewing/plugin-commands-licenses/test/utils/index.ts

@@ -36,6 +36,7 @@ export const DEFAULT_OPTS = {
   rawConfig: { registry: REGISTRY },
   rawLocalConfig: {},
   registries: { default: REGISTRY },
+  rootProjectManifestDir: '',
   // registry: REGISTRY,
   sort: true,
   storeDir: '../store',

reviewing/plugin-commands-listing/test/utils/index.ts

@@ -38,6 +38,7 @@ export const DEFAULT_OPTS = {
   rawLocalConfig: {},
   registries: { default: REGISTRY },
   registry: REGISTRY,
+  rootProjectManifestDir: '',
   sort: true,
   storeDir: '../store',
   strictSsl: false,

reviewing/plugin-commands-outdated/test/utils/index.ts

@@ -41,6 +41,7 @@ export const DEFAULT_OPTS = {
   rawLocalConfig: {},
   registries: { default: REGISTRY },
   registry: REGISTRY,
+  rootProjectManifestDir: '',
   sort: true,
   storeDir: '../store',
   strictSsl: false,