mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-04-10 18:18:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't symlink the autoinstalled peers to the root of node_modules (#4998)

Browse Source 
close #4988
This commit is contained in:
Zoltan Kochan
2022-07-09 00:58:23 +03:00
committed by GitHub
parent 716a29acc9
commit d89bb43f2d
3 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.changeset/early-bats-sell.md Normal file
View File

@@ -0,0 +1,6 @@
---
"@pnpm/core": patch
"pnpm": patch
---
Don't symlink the autoinstalled peer dependencies to the root of `node_modules` [#4988](https://github.com/pnpm/pnpm/issues/4988).

2
packages/core/src/install/link.ts
View File

@@ -160,8 +160,10 @@ export default async function linkPackages (
if (opts.symlink) {
await Promise.all(projects.map(async ({ id, manifest, modulesDir, rootDir }) => {
const deps = opts.dependenciesByProjectId[id]
const importerFromLockfile = newCurrentLockfile.importers[id]
await Promise.all([
...Object.entries(deps)
.filter(([rootAlias]) => importerFromLockfile.specifiers[rootAlias])
.map(([rootAlias, depPath]) => ({ rootAlias, depGraphNode: depGraph[depPath] }))
.filter(({ depGraphNode }) => depGraphNode)
.map(async ({ rootAlias, depGraphNode }) => {

1
packages/core/test/install/autoInstallPeers.ts
View File

@@ -12,6 +12,7 @@ test('auto install non-optional peer dependencies', async () => {
'/abc-optional-peers/1.0.0_peer-a@1.0.0',
'/peer-a/1.0.0',
])
await project.hasNot('peer-a')
})
test('auto install the common peer dependency', async () => {