From de36456d719d2df12a5fe523cdb50bfb3a89e7fc Mon Sep 17 00:00:00 2001 From: zkochan Date: Sat, 14 Oct 2017 16:13:03 +0300 Subject: [PATCH] feat: save 'deprecated' messages in shrinkwrap.yaml --- src/install/installMultiple.ts | 4 ++-- src/link/updateShrinkwrap.ts | 3 +++ src/types.ts | 4 ++++ 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/install/installMultiple.ts b/src/install/installMultiple.ts index 01fe1d688a..281639546d 100644 --- a/src/install/installMultiple.ts +++ b/src/install/installMultiple.ts @@ -308,12 +308,12 @@ async function install ( throw err } } - if (pkg['deprecated']) { + if (pkg.deprecated) { deprecationLogger.warn({ pkgName: pkg.name, pkgVersion: pkg.version, pkgId: fetchedPkg.id, - deprecated: pkg['deprecated'], + deprecated: pkg.deprecated, depth: options.currentDepth, }) } diff --git a/src/link/updateShrinkwrap.ts b/src/link/updateShrinkwrap.ts index 8a8a5315c2..58c72b638e 100644 --- a/src/link/updateShrinkwrap.ts +++ b/src/link/updateShrinkwrap.ts @@ -116,6 +116,9 @@ function toShrDependency ( if (pkg.bundledDependencies || pkg.bundleDependencies) { result['bundledDependencies'] = pkg.bundledDependencies || pkg.bundleDependencies } + if (pkg.deprecated) { + result['deprecated'] = pkg.deprecated + } return result } diff --git a/src/types.ts b/src/types.ts index a8b99196d7..22585e5126 100644 --- a/src/types.ts +++ b/src/types.ts @@ -166,4 +166,8 @@ export type Package = { }, cpu?: string[], os?: string[], + // TODO: create a separate type called PackageManifest that will have `deprecated` + // and won't have `scripts`, `config` and other fields that are not returned by + // the registry + deprecated?: string, }