From e10d046a429827386a43ccfda9544fff6122dde3 Mon Sep 17 00:00:00 2001
From: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
Date: Sat, 25 Mar 2023 17:04:35 -0700
Subject: [PATCH] perf(headless): hoist importerManifestsByImporterId
 calculation (#6282)

---
 .changeset/fifty-boats-drum.md    |  5 +++++
 pkg-manager/headless/src/index.ts | 16 ++++++++--------
 2 files changed, 13 insertions(+), 8 deletions(-)
 create mode 100644 .changeset/fifty-boats-drum.md

diff --git a/.changeset/fifty-boats-drum.md b/.changeset/fifty-boats-drum.md
new file mode 100644
index 0000000000..2e3be14871
--- /dev/null
+++ b/.changeset/fifty-boats-drum.md
@@ -0,0 +1,5 @@
+---
+"@pnpm/headless": patch
+---
+
+Hoist importerManifestsByImporterId calculation
diff --git a/pkg-manager/headless/src/index.ts b/pkg-manager/headless/src/index.ts
index 027cc499dc..20734b2f79 100644
--- a/pkg-manager/headless/src/index.ts
+++ b/pkg-manager/headless/src/index.ts
@@ -607,6 +607,10 @@ async function symlinkDirectDependencies (
     })
   })
   if (symlink !== false) {
+    const importerManifestsByImporterId = {} as { [id: string]: ProjectManifest }
+    for (const { id, manifest } of projects) {
+      importerManifestsByImporterId[id] = manifest
+    }
     const projectsToLink = Object.fromEntries(await Promise.all(
       projects.map(async ({ rootDir, id, modulesDir }) => ([id, {
         dir: rootDir,
@@ -616,7 +620,7 @@ async function symlinkDirectDependencies (
           importerModulesDir: modulesDir,
           lockfileDir,
           projectDir: rootDir,
-          projects,
+          importerManifestsByImporterId,
           registries,
           rootDependencies: directDependenciesByImporterId[id],
         }),
@@ -654,15 +658,11 @@ async function getRootPackagesToLink (
     projectDir: string
     importerId: string
     importerModulesDir: string
-    projects: Array<{ id: string, manifest: ProjectManifest }>
+    importerManifestsByImporterId: { [id: string]: ProjectManifest }
     lockfileDir: string
     rootDependencies: { [alias: string]: string }
   }
 ): Promise<LinkedDirectDep[]> {
-  const importerManifestsByImporterId = {} as { [id: string]: ProjectManifest }
-  for (const { id, manifest } of opts.projects) {
-    importerManifestsByImporterId[id] = manifest
-  }
   const projectSnapshot = lockfile.importers[opts.importerId]
   const allDeps = {
     ...projectSnapshot.devDependencies,
@@ -678,8 +678,8 @@ async function getRootPackagesToLink (
           const packageDir = path.join(opts.projectDir, ref.slice(5))
           const linkedPackage = await (async () => {
             const importerId = getLockfileImporterId(opts.lockfileDir, packageDir)
-            if (importerManifestsByImporterId[importerId]) {
-              return importerManifestsByImporterId[importerId]
+            if (opts.importerManifestsByImporterId[importerId]) {
+              return opts.importerManifestsByImporterId[importerId]
             }
             try {
               // TODO: cover this case with a test