mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2025-12-23 23:29:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: the add command should not fail, when blockExoticSubdeps is true (#10327)

Browse Source 
close #10324
This commit is contained in:
Zoltan Kochan
2025-12-17 11:24:32 +01:00
committed by GitHub
parent c5fbddee05
commit e46a652939
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.changeset/dirty-cases-scream.md Normal file
View File

@@ -0,0 +1,6 @@
---
"@pnpm/resolve-dependencies": patch
"pnpm": patch
---
Don't fail on `pnpm add`, when `blockExoticSubdeps` is set to `true` [#10324](https://github.com/pnpm/pnpm/issues/10324).

BIN
__fixtures__/with-git-protocol-dep/cache/metadata-v1.3/localhost+7769/is-number.v8 vendored Normal file
View File

Binary file not shown.

7
pkg-manager/resolve-dependencies/src/resolveDependencies.ts
View File

@@ -1390,7 +1390,8 @@ async function resolveDependency (
if (
ctx.blockExoticSubdeps &&
options.currentDepth > 0 &&
!isNonExoticDep(pkgResponse.body.resolvedVia)
pkgResponse.body.resolvedVia != null && // This is already coming from the lockfile, we skip the check in this case for now. Should be fixed later.
isExoticDep(pkgResponse.body.resolvedVia)
) {
const error = new PnpmError(
'EXOTIC_SUBDEP',
@@ -1807,6 +1808,6 @@ const NON_EXOTIC_RESOLVED_VIA = new Set([
'workspace',
])
function isNonExoticDep (resolvedVia: string | undefined): boolean {
return resolvedVia != null && NON_EXOTIC_RESOLVED_VIA.has(resolvedVia)
function isExoticDep (resolvedVia: string): boolean {
return !NON_EXOTIC_RESOLVED_VIA.has(resolvedVia)
}