From e50baa8458a4e822f1f06562edbad11b1d95b2e6 Mon Sep 17 00:00:00 2001
From: Zoltan Kochan <z@kochan.io>
Date: Mon, 16 Sep 2024 01:09:31 +0200
Subject: [PATCH] fix: don't print a warning when printing packages globally
 (#8529)

close #4761
---
 .changeset/shaggy-tools-jog.md        | 6 ++++++
 pkg-manager/core/src/install/index.ts | 6 ++++--
 2 files changed, 10 insertions(+), 2 deletions(-)
 create mode 100644 .changeset/shaggy-tools-jog.md

diff --git a/.changeset/shaggy-tools-jog.md b/.changeset/shaggy-tools-jog.md
new file mode 100644
index 0000000000..c94172b10b
--- /dev/null
+++ b/.changeset/shaggy-tools-jog.md
@@ -0,0 +1,6 @@
+---
+"@pnpm/core": patch
+"pnpm": patch
+---
+
+Don't print a warning when linking packages globally [#4761](https://github.com/pnpm/pnpm/issues/4761).
diff --git a/pkg-manager/core/src/install/index.ts b/pkg-manager/core/src/install/index.ts
index 808517b20f..7ecb37fe17 100644
--- a/pkg-manager/core/src/install/index.ts
+++ b/pkg-manager/core/src/install/index.ts
@@ -1333,8 +1333,10 @@ const _installInContext: InstallFunction = async (projects, ctx, opts) => {
       const projectToInstall = projects[index]
       if (opts.global && projectToInstall.mutation.includes('install')) {
         projectToInstall.wantedDependencies.forEach(pkg => {
-          if (!linkedPackages?.includes(pkg.alias)) {
-            logger.warn({ message: `${pkg.alias ?? pkg.pref} has no binaries`, prefix: opts.lockfileDir })
+          // This warning is never printed currently during "pnpm link --global"
+          // due to the following issue: https://github.com/pnpm/pnpm/issues/4761
+          if (pkg.alias && !linkedPackages?.includes(pkg.alias)) {
+            logger.warn({ message: `${pkg.alias} has no binaries`, prefix: opts.lockfileDir })
           }
         })
       }