mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-04-28 02:53:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(validatePeerDependencies): allow combinations (#8946)

Browse Source
This commit is contained in:
Khải
2025-01-08 17:31:37 +07:00
committed by GitHub
parent c27856e789
commit ea58bfdc47
3 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.changeset/fair-ducks-mix.md Normal file
View File

@@ -0,0 +1,6 @@
---
"@pnpm/resolve-dependencies": patch
"pnpm": patch
---
Allow `workspace:` and `catalog:` to be part of wider version range in `peerDependencies`.

3
pkg-manager/resolve-dependencies/src/validatePeerDependencies.ts
View File

@@ -25,5 +25,6 @@ export function validatePeerDependencies (project: ProjectToValidate): void {
}
function isValidPeerVersion (version: string): boolean {
return typeof validRange(version) === 'string' || version.startsWith('workspace:') || version.startsWith('catalog:')
// we use `includes` instead of `startsWith` because `workspace:*` and `catalog:*` could be a part of a wider version range expression
return typeof validRange(version) === 'string' || version.includes('workspace:') || version.includes('catalog:')
}

1
pkg-manager/resolve-dependencies/test/validatePeerDependencies.test.ts
View File

@@ -8,6 +8,7 @@ test('accepts valid specifications that make sense for peerDependencies', () =>
'semver-range': '>=1.2.3 || ^3.2.1',
'workspace-scheme': 'workspace:^',
'catalog-scheme': 'catalog:',
'combine-all': '>=1.2.3 || ^3.2.1 || workspace:^ || catalog:',
},
},
})