mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-04-28 02:53:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolving peer dependencies from linked in dependencies (#6561)

Browse Source
This commit is contained in:
Zoltan Kochan
2023-05-18 16:27:49 +03:00
committed by GitHub
parent bcbfd42c44
commit ee78f144d5
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.changeset/plenty-geckos-applaud.md Normal file
View File

@@ -0,0 +1,6 @@
---
"@pnpm/resolve-dependencies": patch
"pnpm": patch
---
Peers resolution should not fail when a linked in dependency resolves a peer dependency.

3
pkg-manager/resolve-dependencies/src/resolvePeers.ts
View File

@@ -279,6 +279,9 @@ function resolvePeersOfNode<T extends PartialResolvedPackage> (
ctx.pathsByNodeId[cachedNodeId] && ctx.pathsByNodeId[cachedNodeId] &&
ctx.pathsByNodeId[cachedNodeId] === ctx.pathsByNodeId[parentPkgNodeId] ctx.pathsByNodeId[cachedNodeId] === ctx.pathsByNodeId[parentPkgNodeId]
) return true ) return true
if (!ctx.dependenciesTree[parentPkgNodeId] && parentPkgNodeId.startsWith('link:')) {
return false
}
const parentDepPath = (ctx.dependenciesTree[parentPkgNodeId].resolvedPackage as T).depPath const parentDepPath = (ctx.dependenciesTree[parentPkgNodeId].resolvedPackage as T).depPath
if (!ctx.purePkgs.has(parentDepPath)) return false if (!ctx.purePkgs.has(parentDepPath)) return false
const cachedDepPath = (ctx.dependenciesTree[cachedNodeId].resolvedPackage as T).depPath const cachedDepPath = (ctx.dependenciesTree[cachedNodeId].resolvedPackage as T).depPath