From f05845a02f69cfc41eb8740eecd9af7bc19a8265 Mon Sep 17 00:00:00 2001 From: Zoltan Kochan Date: Fri, 15 May 2026 20:59:09 +0200 Subject: [PATCH] fix(pacquet/config): satisfy dylint perfectionist lints (#11672) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two pre-existing perfectionist findings landed via #11526 and broke the Dylint CI job on main: - `perfectionist::macro-trailing-comma` flagged a trailing comma in a single-line `assert_eq!(...)` that `cargo fmt` had collapsed from a multi-line form without dropping the comma. Removed the comma. - `perfectionist::unicode_ellipsis_in_comments` warned about a U+2026 `…` character in a test comment. CI runs with `RUSTFLAGS=-D warnings`, so the warning fails the build. Replaced with ASCII `...`. Verified locally with `cargo dylint --all -- --all-targets --workspace` under `RUSTFLAGS=-D warnings`; passes clean. --- Written by an agent (Claude Code, claude-opus-4-7). --- pacquet/crates/config/src/env_replace.rs | 2 +- pacquet/crates/config/src/npmrc_auth/tests.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pacquet/crates/config/src/env_replace.rs b/pacquet/crates/config/src/env_replace.rs index c0e06bd807..b377894e28 100644 --- a/pacquet/crates/config/src/env_replace.rs +++ b/pacquet/crates/config/src/env_replace.rs @@ -319,6 +319,6 @@ mod tests { fn collects_every_unresolved_placeholder_occurrence() { let (value, unresolved) = env_replace_lossy::("${A}-${B}-${A}"); assert_eq!(value, "--"); - assert_eq!(unresolved, vec!["${A}".to_owned(), "${B}".to_owned(), "${A}".to_owned()],); + assert_eq!(unresolved, vec!["${A}".to_owned(), "${B}".to_owned(), "${A}".to_owned()]); } } diff --git a/pacquet/crates/config/src/npmrc_auth/tests.rs b/pacquet/crates/config/src/npmrc_auth/tests.rs index ba589e0906..ec841a282b 100644 --- a/pacquet/crates/config/src/npmrc_auth/tests.rs +++ b/pacquet/crates/config/src/npmrc_auth/tests.rs @@ -143,7 +143,7 @@ fn env_replace_substitutes_token() { #[test] fn env_replace_failure_warns_and_drops_unresolved_to_empty() { // Mirrors pnpm's `substituteEnv` lossy fallback: unresolved `${VAR}` becomes - // "" so a downstream `Authorization: Bearer …` header is never sent with a + // "" so a downstream `Authorization: Bearer ...` header is never sent with a // literal placeholder. See https://github.com/pnpm/pnpm/issues/11513. let ini = "//reg.com/:_authToken=${MISSING}\n"; let auth = NpmrcAuth::from_ini::(ini);