fix: prevent EBUSY caused by parallel dlx (#8604)

This commit is contained in:
Khải
2024-10-04 09:06:58 +07:00
committed by GitHub
parent fc7eed08c5
commit fb77d4e2fa
2 changed files with 17 additions and 1 deletions

View File

@@ -0,0 +1,6 @@
---
"@pnpm/plugin-commands-script-runners": patch
"pnpm": patch
---
Prevent `EBUSY` errors caused by calling `symlinkDir` in parallel `dlx` processes.

View File

@@ -91,7 +91,17 @@ export async function handler (
saveOptional: false,
savePeer: false,
}, pkgs)
await symlinkDir(cachedDir, cacheLink, { overwrite: true })
try {
await symlinkDir(cachedDir, cacheLink, { overwrite: true })
} catch (error) {
// EBUSY means that there is another dlx process running in parallel that has acquired the cache link first.
// The link created by the other process is just as up-to-date as the link the current process was attempting
// to create. Therefore, instead of re-attempting to create the current link again, it is just as good to let
// the other link stay. The current process should yield.
if (!util.types.isNativeError(error) || !('code' in error) || error.code !== 'EBUSY') {
throw error
}
}
}
const modulesDir = path.join(cachedDir, 'node_modules')
const binsDir = path.join(modulesDir, '.bin')