Commit Graph

12 Commits

Author SHA1 Message Date
mato533
d6a4ff1892 feat(git-resolver): respect proxy settings when resolving git (#9016)
close: #6530
2025-01-28 18:48:37 +01:00
Utsav Shah
b10096228c fix(git-resolver): handle private git repo resolution (#8906)
* fix(git-resolver): handle private git repo resolution

In the case where:

1. No git auth token was specified by the user
2. The package requested to be fetched via https
3. The user does not have SSH access to the repo but has HTTPS access
4. The package was hosted in a private GitHub repo

pnpm would fallback to using SSH since it was a "likely private repo"
and would fail to resolve the package. Now, rather than only checking if
there is an auth token specified, it also checks both:

1. Is the repo private
2. Does the user have access to ls-remote it.

And if these conditions are true, it tries to use https anyway.

This matches the behavior of npm and Yarn berry. Yarn classic also has
this bug, and there's a code comment that alludes to it.
2024-12-27 02:48:59 +01:00
btea
e8c0ae354b chore: remove unnecessary comment (#8896) 2024-12-22 01:43:09 +01:00
btea
9797a1e889 refactor: remove useless parameters from the catch statement (#8583) 2024-09-29 12:08:48 +02:00
Khải
45243a5c63 refactor(resolving): type checking perf (#7883) 2024-04-10 10:52:33 +02:00
Rex Zeng
b13d2dc1ae feat: add sub folder support for git url (#7487)
close #4765

---------

Co-authored-by: Zoltan Kochan <z@kochan.io>
2024-01-24 02:15:02 +01:00
Zoltan Kochan
733d612ad1 test: check spelling with cspell (#7229) 2023-10-20 15:58:27 +03:00
Khải
22bbe92554 feat(git-resolver): fix private git repo (#6832)
fixes #6827
closes #6829
2023-07-19 13:48:05 +03:00
Zoltan Kochan
de9b6c20d4 revert: "fix(git-resolver): wrong scheme to git ls-remote (#6806)"
This reverts commit 6fe0b60e61.

ref #6827
2023-07-18 12:44:51 +03:00
Khải
6fe0b60e61 fix(git-resolver): wrong scheme to git ls-remote (#6806)
close #6805
2023-07-17 11:40:54 +03:00
Andrei Neculau
28796377cb fix: handle git+ssh with semver (#6239) 2023-03-21 00:40:26 +02:00
Zoltan Kochan
4ca53b0b50 refactor: group projects in different subdirectories (#5659) 2022-11-20 01:35:22 +02:00