mirror/pnpm
1
0 Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-10-31 03:58:35 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
docs-no-modify-path
pnpm/pnpm11/resolving/git-resolver/test/parsePref.test.ts
T
Zoltan Kochan 4edeef9176 style(ts): port the perfectionist lint rules to ESLint (#16415) 
Add TypeScript ports of the perfectionist rules that the Rust workspace
enforces through dylint.toml to @pnpm/eslint-config, with the same limits,
and fix every finding that needs no refactor.

The size and shape rules (function length, cognitive complexity, nesting,
local bindings, file length) are enforced for packages that already meet
them. The packages that do not are listed in PENDING_SIZE_AND_SHAPE_REFACTOR
in eslint.config.mjs and are refactored in follow-up changes.

The custom rules mirror perfectionist's semantics rather than reusing
sonarjs or max-lines-per-function, so that one limit means the same thing
in both codebases: a closure is a level of the body that contains it, a
nested function declaration is measured on its own, and a test-framework
callback plays the role of a #[test] function.

Bugs found and fixed along the way:
- a registry error body cut at exactly 64 KiB lost its truncation marker
- removing a dependency could leave dangling .bin shims
- constructor/__proto__ names crashed the projects graph, were skipped by
  the injected-deps syncer, and were dropped from writeWantedLockfile's
  returned lockfile

The CI chunk runner learns to run the node:test suite of the ESLint
config package.
2026-09-30 15:10:08 +02:00

118 lines
6.8 KiB
TypeScript
Raw Permalink Blame History

import { expect, jest, test } from '@jest/globals'
jest.unstable_mockModule('@pnpm/network.fetch', () => ({
fetchWithDispatcher: jest.fn(async () => ({ ok: true })),
}))
jest.unstable_mockModule('execa', () => ({
safeExeca: jest.fn(async () => ({ stdout: '' })),
}))
const { parseBareSpecifier } = await import('../lib/parseBareSpecifier.js')
test.each([
['ssh://username:password@example.com:repo.git', 'ssh://username:password@example.com/repo.git'],
['ssh://username:password@example.com:repo/@foo.git', 'ssh://username:password@example.com/repo/@foo.git'],
['ssh://username:password@example.com:22/repo/@foo.git', 'ssh://username:password@example.com:22/repo/@foo.git'],
['ssh://username:password@example.com:22repo/@foo.git', 'ssh://username:password@example.com/22repo/@foo.git'],
['ssh://username:password@example.com:22/repo/@foo.git#path:/a/@b', 'ssh://username:password@example.com:22/repo/@foo.git'],
['ssh://username:password@example.com:22/repo/@foo.git#path:/a/@b&dev', 'ssh://username:password@example.com:22/repo/@foo.git'],
['git+ssh://username:password@example.com:repo.git', 'ssh://username:password@example.com/repo.git'],
['git+ssh://username:password@example.com:repo/@foo.git', 'ssh://username:password@example.com/repo/@foo.git'],
['git+ssh://username:password@example.com:22/repo/@foo.git', 'ssh://username:password@example.com:22/repo/@foo.git'],
['git+ssh://username:password@example.com:22/repo/@foo.git#path:/a/@b', 'ssh://username:password@example.com:22/repo/@foo.git'],
['git+ssh://username:password@example.com:22/repo/@foo.git#path:/a/@b&dev', 'ssh://username:password@example.com:22/repo/@foo.git'],
])('the right colon is escaped in %s', async (input, output) => {
const parsed = await parseBareSpecifier(input, {})?.()
expect(parsed?.fetchSpec).toBe(output)
})
test.each([
['ssh://username:password@example.com:repo.git#path:/a/@b', '/a/@b'],
['ssh://username:password@example.com:repo/@foo.git#path:/a/@b', '/a/@b'],
['ssh://username:password@example.com:22/repo/@foo.git#path:/a/@b', '/a/@b'],
['ssh://username:password@example.com:22repo/@foo.git#path:/a/@b', '/a/@b'],
['ssh://username:password@example.com:22/repo/@foo.git#path:/a/@b', '/a/@b'],
['ssh://username:password@example.com:22/repo/@foo.git#path:/a/@b&dev', '/a/@b'],
['git+ssh://username:password@example.com:repo.git#path:/a/@b', '/a/@b'],
['git+ssh://username:password@example.com:repo/@foo.git#path:/a/@b', '/a/@b'],
['git+ssh://username:password@example.com:22/repo/@foo.git#path:/a/@b', '/a/@b'],
['git+ssh://username:password@example.com:22/repo/@foo.git#path:/a/@b', '/a/@b'],
['git+ssh://username:password@example.com:22/repo/@foo.git#path:/a/@b&dev', '/a/@b'],
['ssh://username:password@example.com:repo.git', undefined],
['ssh://username:password@example.com:repo/@foo.git', undefined],
['ssh://username:password@example.com:22/repo/@foo.git', undefined],
['ssh://username:password@example.com:22repo/@foo.git', undefined],
['ssh://username:password@example.com:22/repo/@foo.git', undefined],
['ssh://username:password@example.com:22/repo/@foo.git#dev', undefined],
['git+ssh://username:password@example.com:repo.git', undefined],
['git+ssh://username:password@example.com:repo/@foo.git', undefined],
['git+ssh://username:password@example.com:22/repo/@foo.git', undefined],
['git+ssh://username:password@example.com:22/repo/@foo.git', undefined],
['git+ssh://username:password@example.com:22/repo/@foo.git#dev', undefined],
])('the path of %s should be %s', async (input, output) => {
const parsed = await parseBareSpecifier(input, {})?.()
expect(parsed?.path).toBe(output)
})
test.each([
['git+https://github.com/pnpm/pnpm.git', 'https://github.com/pnpm/pnpm.git'],
['git+ssh://git@sub.domain.tld:internal-app/sub-path/service-name.git', 'ssh://git@sub.domain.tld/internal-app/sub-path/service-name.git'],
])('the fetchSpec of %s should be %s', async (input, output) => {
const parsed = await parseBareSpecifier(input, {})?.()
expect(parsed?.fetchSpec).toBe(output)
})
test.each([
['ssh://git.example.com/team/repo.git', 'ssh://git.example.com/team/repo.git'],
['ssh://git.example.com:2222/team/repo.git', 'ssh://git.example.com:2222/team/repo.git'],
['ssh://git.example.com:team/repo.git', 'ssh://git.example.com/team/repo.git'],
['ssh://git.example.com:repo.git', 'ssh://git.example.com/repo.git'],
['git+ssh://git.example.com/team/repo.git', 'ssh://git.example.com/team/repo.git'],
['git+ssh://git.example.com:team/repo.git', 'ssh://git.example.com/team/repo.git'],
['ssh://git.example.com:2222/team/repo.git#v1.0.0', 'ssh://git.example.com:2222/team/repo.git'],
])('the fetchSpec of %s, which carries no user info, should be %s', async (input, output) => {
const parsed = await parseBareSpecifier(input, {})?.()
expect(parsed?.fetchSpec).toBe(output)
})
test.each([
['ssh://user@a@b.example.com/repo.git', 'ssh://user%40a@b.example.com/repo.git'],
['ssh://user:p@ss@example.com:repo.git', 'ssh://user:p%40ss@example.com/repo.git'],
['ssh://user:p@ss@example.com:22/repo.git', 'ssh://user:p%40ss@example.com:22/repo.git'],
])('the fetchSpec of %s, whose authority holds more than one @, should be %s', async (input, output) => {
const parsed = await parseBareSpecifier(input, {})?.()
expect(parsed?.fetchSpec).toBe(output)
})
test.each([
['ssh://[::1]/repo.git', 'ssh://[::1]/repo.git'],
['ssh://[2001:db8::1]/team/repo.git', 'ssh://[2001:db8::1]/team/repo.git'],
['ssh://[::1]:2222/repo.git', 'ssh://[::1]:2222/repo.git'],
['ssh://[::1]:team/repo.git', 'ssh://[::1]/team/repo.git'],
['ssh://git@[::1]/repo.git', 'ssh://git@[::1]/repo.git'],
['ssh://git@[::1]:team/repo.git', 'ssh://git@[::1]/team/repo.git'],
])('the fetchSpec of %s, which holds a bracketed IPv6 host, should be %s', async (input, output) => {
const parsed = await parseBareSpecifier(input, {})?.()
expect(parsed?.fetchSpec).toBe(output)
})
// Test for https:// URLs ending in .git (issue pnpm/pnpm#10468)
test.each([
['https://gitea.osmocom.org/ttcn3/highlightjs-ttcn3.git', 'https://gitea.osmocom.org/ttcn3/highlightjs-ttcn3.git'],
['https://gitea.osmocom.org/ttcn3/highlightjs-ttcn3.git#6daccff309fca1e7561a43984d42fa4f829ce06d', 'https://gitea.osmocom.org/ttcn3/highlightjs-ttcn3.git'],
['http://example.com/repo.git', 'http://example.com/repo.git'],
['http://example.com/repo.git#main', 'http://example.com/repo.git'],
])('plain http/https URLs ending in .git should be recognized: %s', async (input, output) => {
const parsed = await parseBareSpecifier(input, {})?.()
expect(parsed?.fetchSpec).toBe(output)
})
// Ensure non-.git https URLs are not recognized as git repos
test.each([
['https://example.com/package.tar.gz'],
['https://example.com/package.tgz'],
['https://example.com/file'],
])('plain http/https URLs not ending in .git should not be recognized: %s', async (input) => {
const parsed = parseBareSpecifier(input, {})
expect(parsed).toBeNull()
})
Reference in new issue View Git Blame Copy Permalink