mirror of
https://github.com/pnpm/pnpm.git
synced 2026-03-27 19:41:44 -04:00
## Summary Rename all internal packages so their npm names follow the `@pnpm/<domain>.<leaf>` convention, matching their directory structure. Also rename directories to remove redundancy and improve clarity. ### Bulk rename (94 packages) All `@pnpm/` packages now derive their name from their directory path using dot-separated segments. Exceptions: `packages/`, `__utils__/`, and `pnpm/artifacts/` keep leaf names only. ### Directory renames (removing redundant prefixes) - `cli/cli-meta` → `cli/meta`, `cli/cli-utils` → `cli/utils` - `config/config` → `config/reader`, `config/config-writer` → `config/writer` - `fetching/fetching-types` → `fetching/types` - `lockfile/lockfile-to-pnp` → `lockfile/to-pnp` - `store/store-connection-manager` → `store/connection-manager` - `store/store-controller-types` → `store/controller-types` - `store/store-path` → `store/path` ### Targeted renames (clarity improvements) - `deps/dependency-path` → `deps/path` (`@pnpm/deps.path`) - `deps/calc-dep-state` → `deps/graph-hasher` (`@pnpm/deps.graph-hasher`) - `deps/inspection/dependencies-hierarchy` → `deps/inspection/tree-builder` (`@pnpm/deps.inspection.tree-builder`) - `bins/link-bins` → `bins/linker`, `bins/remove-bins` → `bins/remover`, `bins/package-bins` → `bins/resolver` - `installing/get-context` → `installing/context` - `store/package-store` → `store/controller` - `pkg-manifest/manifest-utils` → `pkg-manifest/utils` ### Manifest reader/writer renames - `workspace/read-project-manifest` → `workspace/project-manifest-reader` (`@pnpm/workspace.project-manifest-reader`) - `workspace/write-project-manifest` → `workspace/project-manifest-writer` (`@pnpm/workspace.project-manifest-writer`) - `workspace/read-manifest` → `workspace/workspace-manifest-reader` (`@pnpm/workspace.workspace-manifest-reader`) - `workspace/manifest-writer` → `workspace/workspace-manifest-writer` (`@pnpm/workspace.workspace-manifest-writer`) ### Workspace package renames - `workspace/find-packages` → `workspace/projects-reader` - `workspace/find-workspace-dir` → `workspace/root-finder` - `workspace/resolve-workspace-range` → `workspace/range-resolver` - `workspace/filter-packages-from-dir` merged into `workspace/filter-workspace-packages` → `workspace/projects-filter` ### Domain moves - `pkg-manifest/read-project-manifest` → `workspace/project-manifest-reader` - `pkg-manifest/write-project-manifest` → `workspace/project-manifest-writer` - `pkg-manifest/exportable-manifest` → `releasing/exportable-manifest` ### Scope - 1206 files changed - Updated: package.json names/deps, TypeScript imports, tsconfig references, changeset files, renovate.json, test fixtures, import ordering
132 lines
3.5 KiB
TypeScript
132 lines
3.5 KiB
TypeScript
import fs from 'node:fs'
|
|
import path from 'node:path'
|
|
|
|
import { jest } from '@jest/globals'
|
|
import type { VerifyDepsBeforeRun } from '@pnpm/config.reader'
|
|
import { prepare } from '@pnpm/prepare'
|
|
|
|
import { DEFAULT_OPTS } from './utils/index.js'
|
|
|
|
const originalModule = await import('@pnpm/logger')
|
|
jest.unstable_mockModule('@pnpm/logger', () => {
|
|
return {
|
|
...originalModule,
|
|
globalWarn: jest.fn(),
|
|
}
|
|
})
|
|
|
|
jest.unstable_mockModule('enquirer', () => ({
|
|
default: {
|
|
prompt: jest.fn(),
|
|
},
|
|
}))
|
|
|
|
const { run } = await import('@pnpm/exec.commands')
|
|
const { default: enquirer } = await import('enquirer')
|
|
const { globalWarn } = await import('@pnpm/logger')
|
|
|
|
const rootProjectManifest = {
|
|
name: 'root',
|
|
private: true,
|
|
dependencies: {
|
|
'is-positive': '1.0.0',
|
|
},
|
|
scripts: {
|
|
test: 'echo hello from script',
|
|
},
|
|
}
|
|
|
|
async function runTest (verifyDepsBeforeRun: VerifyDepsBeforeRun): Promise<void> {
|
|
await run.handler({
|
|
...DEFAULT_OPTS,
|
|
bin: 'node_modules/.bin',
|
|
dir: process.cwd(),
|
|
extraBinPaths: [],
|
|
extraEnv: {},
|
|
pnpmHomeDir: '',
|
|
rawConfig: {},
|
|
verifyDepsBeforeRun,
|
|
rootProjectManifest,
|
|
rootProjectManifestDir: process.cwd(),
|
|
}, ['test'])
|
|
}
|
|
|
|
test('throw an error if verifyDepsBeforeRun is set to error', async () => {
|
|
prepare(rootProjectManifest)
|
|
|
|
let err!: Error
|
|
try {
|
|
await runTest('error')
|
|
} catch (_err) {
|
|
err = _err as Error
|
|
}
|
|
expect(err.message).toContain('Cannot check whether dependencies are outdated')
|
|
})
|
|
|
|
test('install the dependencies if verifyDepsBeforeRun is set to install', async () => {
|
|
prepare(rootProjectManifest)
|
|
|
|
await runTest('install')
|
|
|
|
expect(fs.existsSync(path.resolve('node_modules'))).toBeTruthy()
|
|
})
|
|
|
|
test('log a warning if verifyDepsBeforeRun is set to warn', async () => {
|
|
prepare(rootProjectManifest)
|
|
|
|
await runTest('warn')
|
|
|
|
expect(globalWarn).toHaveBeenCalledWith(
|
|
expect.stringContaining('Your node_modules are out of sync with your lockfile')
|
|
)
|
|
expect(fs.existsSync(path.resolve('node_modules'))).toBeFalsy()
|
|
})
|
|
|
|
test('prompt the user if verifyDepsBeforeRun is set to prompt', async () => {
|
|
prepare(rootProjectManifest)
|
|
|
|
// Mock the user confirming the prompt
|
|
jest.mocked(enquirer.prompt).mockResolvedValue({ runInstall: true })
|
|
|
|
const originalIsTTY = process.stdin.isTTY
|
|
Object.defineProperty(process.stdin, 'isTTY', { value: true, configurable: true })
|
|
|
|
try {
|
|
await runTest('prompt')
|
|
} finally {
|
|
Object.defineProperty(process.stdin, 'isTTY', { value: originalIsTTY, configurable: true })
|
|
}
|
|
|
|
expect(enquirer.prompt).toHaveBeenCalledWith({
|
|
type: 'confirm',
|
|
name: 'runInstall',
|
|
message: expect.stringContaining(
|
|
'Your "node_modules" directory is out of sync with the "pnpm-lock.yaml" file'
|
|
),
|
|
initial: true,
|
|
})
|
|
|
|
expect(fs.existsSync(path.resolve('node_modules'))).toBeTruthy()
|
|
})
|
|
|
|
test('throw an error if verifyDepsBeforeRun is set to prompt in non-TTY environment', async () => {
|
|
prepare(rootProjectManifest)
|
|
|
|
// Mock non-TTY environment
|
|
const originalIsTTY = process.stdin.isTTY
|
|
Object.defineProperty(process.stdin, 'isTTY', { value: false, configurable: true })
|
|
|
|
let err!: Error
|
|
try {
|
|
await runTest('prompt')
|
|
} catch (_err) {
|
|
err = _err as Error
|
|
} finally {
|
|
// Restore original value
|
|
Object.defineProperty(process.stdin, 'isTTY', { value: originalIsTTY, configurable: true })
|
|
}
|
|
|
|
expect(err.message).toContain('Cannot check whether dependencies are outdated')
|
|
expect(fs.existsSync(path.resolve('node_modules'))).toBeFalsy()
|
|
})
|