mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-18 22:02:53 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
84 lines
3.1 KiB
TypeScript
84 lines
3.1 KiB
TypeScript
import fs from 'node:fs'
|
|
|
|
import { expect, test } from '@jest/globals'
|
|
import type { PnpmError } from '@pnpm/error'
|
|
import { addDependenciesToPackage, mutateModulesInSingleProject } from '@pnpm/installing.deps-installer'
|
|
import { prepareEmpty } from '@pnpm/prepare'
|
|
import { REGISTRY_MOCK_PORT } from '@pnpm/registry-mock'
|
|
import { fixtures } from '@pnpm/test-fixtures'
|
|
import { getMockAgent, setupMockAgent, teardownMockAgent } from '@pnpm/testing.mock-agent'
|
|
import type { ProjectRootDir } from '@pnpm/types'
|
|
import { loadJsonFileSync } from 'load-json-file'
|
|
|
|
import { testDefaults } from '../utils/index.js'
|
|
|
|
const f = fixtures(import.meta.dirname)
|
|
|
|
test('fail if none of the available resolvers support a version spec', async () => {
|
|
prepareEmpty()
|
|
|
|
let err!: PnpmError
|
|
try {
|
|
await mutateModulesInSingleProject({
|
|
manifest: {
|
|
dependencies: {
|
|
'@types/plotly.js': '1.44.29',
|
|
},
|
|
},
|
|
mutation: 'install',
|
|
rootDir: process.cwd() as ProjectRootDir,
|
|
}, testDefaults())
|
|
throw new Error('should have failed')
|
|
} catch (_err: any) { // eslint-disable-line
|
|
err = _err
|
|
}
|
|
expect(err.code).toBe('ERR_PNPM_SPEC_NOT_SUPPORTED_BY_ANY_RESOLVER')
|
|
expect(err.prefix).toBe(process.cwd())
|
|
expect(err.pkgsStack).toStrictEqual(
|
|
[
|
|
{
|
|
id: '@types/plotly.js@1.44.29',
|
|
name: '@types/plotly.js',
|
|
version: '1.44.29',
|
|
},
|
|
]
|
|
)
|
|
})
|
|
|
|
test('fail if a package cannot be fetched', async () => {
|
|
prepareEmpty()
|
|
await setupMockAgent()
|
|
const mockPool = getMockAgent().get(`http://localhost:${REGISTRY_MOCK_PORT}`)
|
|
/* eslint-disable @typescript-eslint/no-explicit-any */
|
|
mockPool.intercept({ path: '/@pnpm.e2e%2Fpkg-with-1-dep', method: 'GET' }) // cspell:disable-line
|
|
.reply(200, loadJsonFileSync<any>(f.find('pkg-with-1-dep.json')))
|
|
mockPool.intercept({ path: '/@pnpm.e2e%2Fdep-of-pkg-with-1-dep', method: 'GET' }) // cspell:disable-line
|
|
.reply(200, loadJsonFileSync<any>(f.find('dep-of-pkg-with-1-dep.json')))
|
|
/* eslint-enable @typescript-eslint/no-explicit-any */
|
|
const tarballContent = fs.readFileSync(f.find('pkg-with-1-dep-100.0.0.tgz'))
|
|
mockPool.intercept({ path: '/@pnpm.e2e/pkg-with-1-dep/-/@pnpm.e2e/pkg-with-1-dep-100.0.0.tgz', method: 'GET' })
|
|
.reply(200, tarballContent, { headers: { 'content-length': String(tarballContent.length) } })
|
|
mockPool.intercept({ path: '/@pnpm.e2e/dep-of-pkg-with-1-dep/-/@pnpm.e2e/dep-of-pkg-with-1-dep-100.1.0.tgz', method: 'GET' })
|
|
.reply(403, 'Forbidden', { headers: { 'content-type': 'text/plain' } })
|
|
|
|
let err!: PnpmError
|
|
try {
|
|
await addDependenciesToPackage({}, ['@pnpm.e2e/pkg-with-1-dep@100.0.0'], testDefaults({}, {}, { retry: { retries: 0 } }))
|
|
throw new Error('should have failed')
|
|
} catch (_err: any) { // eslint-disable-line
|
|
await teardownMockAgent()
|
|
err = _err
|
|
}
|
|
expect(err.code).toBe('ERR_PNPM_FETCH_403')
|
|
expect(err.prefix).toBe(process.cwd())
|
|
expect(err.pkgsStack).toStrictEqual(
|
|
[
|
|
{
|
|
id: '@pnpm.e2e/pkg-with-1-dep@100.0.0',
|
|
name: '@pnpm.e2e/pkg-with-1-dep',
|
|
version: '100.0.0',
|
|
},
|
|
]
|
|
)
|
|
})
|