mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-12 10:11:42 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
85 lines
3.9 KiB
TypeScript
85 lines
3.9 KiB
TypeScript
import { expect, test } from '@jest/globals'
|
|
|
|
import { getObjectValueByPropertyPathString } from '../src/index.js'
|
|
|
|
const OBJECT = {
|
|
packages: [
|
|
'foo',
|
|
'bar',
|
|
],
|
|
|
|
catalogs: {
|
|
default: {
|
|
'is-positive': '^1.0.0',
|
|
'is-negative': '^1.0.0',
|
|
},
|
|
},
|
|
|
|
packageExtensions: {
|
|
'@babel/parser': {
|
|
peerDependencies: {
|
|
unified: '*',
|
|
},
|
|
},
|
|
},
|
|
|
|
updateConfig: {
|
|
ignoreDependencies: [
|
|
'boxen',
|
|
'camelcase',
|
|
'find-up',
|
|
],
|
|
},
|
|
} as const
|
|
|
|
test('path exists', () => {
|
|
expect(getObjectValueByPropertyPathString(OBJECT, '')).toBe(OBJECT)
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'packages')).toBe(OBJECT.packages)
|
|
expect(getObjectValueByPropertyPathString(OBJECT, '.packages')).toBe(OBJECT.packages)
|
|
expect(getObjectValueByPropertyPathString(OBJECT, '["packages"]')).toBe(OBJECT.packages)
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'packages[0]')).toBe(OBJECT.packages[0])
|
|
expect(getObjectValueByPropertyPathString(OBJECT, '.packages[0]')).toBe(OBJECT.packages[0])
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'packages[1]')).toBe(OBJECT.packages[1])
|
|
expect(getObjectValueByPropertyPathString(OBJECT, '.packages[1]')).toBe(OBJECT.packages[1])
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'catalogs')).toBe(OBJECT.catalogs)
|
|
expect(getObjectValueByPropertyPathString(OBJECT, '.catalogs')).toBe(OBJECT.catalogs)
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'catalogs.default')).toBe(OBJECT.catalogs.default)
|
|
expect(getObjectValueByPropertyPathString(OBJECT, '.catalogs.default')).toBe(OBJECT.catalogs.default)
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'catalogs.default["is-positive"]')).toBe(OBJECT.catalogs.default['is-positive'])
|
|
expect(getObjectValueByPropertyPathString(OBJECT, '.catalogs.default["is-positive"]')).toBe(OBJECT.catalogs.default['is-positive'])
|
|
})
|
|
|
|
test('path does not exist', () => {
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'notExist')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString(OBJECT, '.notExist')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'catalogs.notExist')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString(OBJECT, '.notExist.catalogs')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'catalogs.default.notExist')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString(OBJECT, '.catalogs.notExist.default')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'packages[99]')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'packages[0].foo')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'catalogs.default["not-exist"]')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'catalogs.default["is-positive"].foo')).toBeUndefined()
|
|
})
|
|
|
|
test('does not leak JavaScript-specific properties', () => {
|
|
expect(getObjectValueByPropertyPathString({}, 'constructor')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString([], 'length')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString('foo', 'length')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString(0, 'valueOf')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString(class {}, 'prototype')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'constructor')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'packages.length')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString(OBJECT, 'packages[0].length')).toBeUndefined()
|
|
})
|
|
|
|
test('non-objects', () => {
|
|
expect(getObjectValueByPropertyPathString(0, '')).toBe(0)
|
|
expect(getObjectValueByPropertyPathString('foo', '')).toBe('foo')
|
|
})
|
|
|
|
test('does not allow accessing specific character in a string', () => {
|
|
expect(getObjectValueByPropertyPathString('foo', '[0]')).toBeUndefined()
|
|
expect(getObjectValueByPropertyPathString('foo', '["0"]')).toBeUndefined()
|
|
})
|