Files
pnpm/store/controller/test/projectRegistry.ts
Zoltan Kochan 4a36b9a110 refactor: rename internal packages to @pnpm/<domain>.<leaf> convention (#10997)
## Summary

Rename all internal packages so their npm names follow the `@pnpm/<domain>.<leaf>` convention, matching their directory structure. Also rename directories to remove redundancy and improve clarity.

### Bulk rename (94 packages)

All `@pnpm/` packages now derive their name from their directory path using dot-separated segments. Exceptions: `packages/`, `__utils__/`, and `pnpm/artifacts/` keep leaf names only.

### Directory renames (removing redundant prefixes)

- `cli/cli-meta` → `cli/meta`, `cli/cli-utils` → `cli/utils`
- `config/config` → `config/reader`, `config/config-writer` → `config/writer`
- `fetching/fetching-types` → `fetching/types`
- `lockfile/lockfile-to-pnp` → `lockfile/to-pnp`
- `store/store-connection-manager` → `store/connection-manager`
- `store/store-controller-types` → `store/controller-types`
- `store/store-path` → `store/path`

### Targeted renames (clarity improvements)

- `deps/dependency-path` → `deps/path` (`@pnpm/deps.path`)
- `deps/calc-dep-state` → `deps/graph-hasher` (`@pnpm/deps.graph-hasher`)
- `deps/inspection/dependencies-hierarchy` → `deps/inspection/tree-builder` (`@pnpm/deps.inspection.tree-builder`)
- `bins/link-bins` → `bins/linker`, `bins/remove-bins` → `bins/remover`, `bins/package-bins` → `bins/resolver`
- `installing/get-context` → `installing/context`
- `store/package-store` → `store/controller`
- `pkg-manifest/manifest-utils` → `pkg-manifest/utils`

### Manifest reader/writer renames

- `workspace/read-project-manifest` → `workspace/project-manifest-reader` (`@pnpm/workspace.project-manifest-reader`)
- `workspace/write-project-manifest` → `workspace/project-manifest-writer` (`@pnpm/workspace.project-manifest-writer`)
- `workspace/read-manifest` → `workspace/workspace-manifest-reader` (`@pnpm/workspace.workspace-manifest-reader`)
- `workspace/manifest-writer` → `workspace/workspace-manifest-writer` (`@pnpm/workspace.workspace-manifest-writer`)

### Workspace package renames

- `workspace/find-packages` → `workspace/projects-reader`
- `workspace/find-workspace-dir` → `workspace/root-finder`
- `workspace/resolve-workspace-range` → `workspace/range-resolver`
- `workspace/filter-packages-from-dir` merged into `workspace/filter-workspace-packages` → `workspace/projects-filter`

### Domain moves

- `pkg-manifest/read-project-manifest` → `workspace/project-manifest-reader`
- `pkg-manifest/write-project-manifest` → `workspace/project-manifest-writer`
- `pkg-manifest/exportable-manifest` → `releasing/exportable-manifest`

### Scope

- 1206 files changed
- Updated: package.json names/deps, TypeScript imports, tsconfig references, changeset files, renovate.json, test fixtures, import ordering
2026-03-17 21:50:40 +01:00

124 lines
4.3 KiB
TypeScript

/// <reference path="../../../__typings__/index.d.ts"/>
import { promises as fs } from 'node:fs'
import path from 'node:path'
import { getRegisteredProjects, registerProject } from '@pnpm/store.controller'
import { temporaryDirectory } from 'tempy'
describe('projectRegistry', () => {
describe('registerProject()', () => {
it('creates a symlink in the projects directory', async () => {
const storeDir = temporaryDirectory()
const projectDir = temporaryDirectory()
await registerProject(storeDir, projectDir)
// Check that projects directory was created
const projectsDir = path.join(storeDir, 'projects')
const entries = await fs.readdir(projectsDir)
expect(entries).toHaveLength(1)
// Check that the symlink points to the project
const linkPath = path.join(projectsDir, entries[0])
const target = await fs.readlink(linkPath)
expect(path.resolve(path.dirname(linkPath), target)).toBe(projectDir)
})
it('is idempotent - registering the same project twice works', async () => {
const storeDir = temporaryDirectory()
const projectDir = temporaryDirectory()
await registerProject(storeDir, projectDir)
await registerProject(storeDir, projectDir)
const projectsDir = path.join(storeDir, 'projects')
const entries = await fs.readdir(projectsDir)
expect(entries).toHaveLength(1)
})
it('registers multiple projects with different hashes', async () => {
const storeDir = temporaryDirectory()
const projectDir1 = temporaryDirectory()
const projectDir2 = temporaryDirectory()
await registerProject(storeDir, projectDir1)
await registerProject(storeDir, projectDir2)
const projectsDir = path.join(storeDir, 'projects')
const entries = await fs.readdir(projectsDir)
expect(entries).toHaveLength(2)
})
it('does not create symlink when store is inside project directory', async () => {
const projectDir = temporaryDirectory()
const storeDir = path.join(projectDir, 'node_modules', '.pnpm-store')
await fs.mkdir(storeDir, { recursive: true })
await registerProject(storeDir, projectDir)
// The projects directory should not be created since we skipped registration
const projectsDir = path.join(storeDir, 'projects')
await expect(fs.readdir(projectsDir)).rejects.toThrow(/ENOENT/)
})
})
describe('getRegisteredProjects()', () => {
it('returns empty array when no projects are registered', async () => {
const storeDir = temporaryDirectory()
const projects = await getRegisteredProjects(storeDir)
expect(projects).toEqual([])
})
it('returns registered project paths', async () => {
const storeDir = temporaryDirectory()
const projectDir1 = temporaryDirectory()
const projectDir2 = temporaryDirectory()
await registerProject(storeDir, projectDir1)
await registerProject(storeDir, projectDir2)
const projects = await getRegisteredProjects(storeDir)
expect(projects.sort()).toEqual([projectDir1, projectDir2].sort())
})
it('cleans up stale entries for deleted projects', async () => {
const storeDir = temporaryDirectory()
const projectDir = temporaryDirectory()
await registerProject(storeDir, projectDir)
// Verify project is registered
let projects = await getRegisteredProjects(storeDir)
expect(projects).toEqual([projectDir])
// Delete the project directory
await fs.rm(projectDir, { recursive: true })
// getRegisteredProjects should clean up stale entry
projects = await getRegisteredProjects(storeDir)
expect(projects).toEqual([])
// Verify the symlink was removed
const projectsDir = path.join(storeDir, 'projects')
const entries = await fs.readdir(projectsDir)
expect(entries).toEqual([])
})
it('handles mix of valid and stale entries', async () => {
const storeDir = temporaryDirectory()
const validProject = temporaryDirectory()
const staleProject = temporaryDirectory()
await registerProject(storeDir, validProject)
await registerProject(storeDir, staleProject)
// Delete one project
await fs.rm(staleProject, { recursive: true })
const projects = await getRegisteredProjects(storeDir)
expect(projects).toEqual([validProject])
})
})
})