mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-12 10:11:42 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
74 lines
2.4 KiB
TypeScript
74 lines
2.4 KiB
TypeScript
import fs from 'node:fs'
|
|
import path from 'node:path'
|
|
|
|
import { afterEach, beforeEach, expect, jest, test } from '@jest/globals'
|
|
import { logger } from '@pnpm/logger'
|
|
import { prepareEmpty } from '@pnpm/prepare'
|
|
import type { ProjectRootDir } from '@pnpm/types'
|
|
|
|
import { getFilePath } from '../src/filePath.js'
|
|
import { loadWorkspaceState, type WorkspaceState } from '../src/index.js'
|
|
|
|
const lastValidatedTimestamp = Date.now()
|
|
|
|
const originalLoggerDebug = logger.debug
|
|
beforeEach(() => {
|
|
logger.debug = jest.fn(originalLoggerDebug)
|
|
})
|
|
afterEach(() => {
|
|
logger.debug = originalLoggerDebug
|
|
})
|
|
|
|
const expectedLoggerCalls = [[{ msg: 'loading workspace state' }]]
|
|
|
|
test('loadWorkspaceState() when cache dir does not exist', async () => {
|
|
prepareEmpty()
|
|
const workspaceDir = process.cwd()
|
|
expect(loadWorkspaceState(workspaceDir)).toBeUndefined()
|
|
expect(jest.mocked(logger.debug).mock.calls).toStrictEqual(expectedLoggerCalls)
|
|
})
|
|
|
|
test('loadWorkspaceState() when cache dir exists but not the file', async () => {
|
|
prepareEmpty()
|
|
const workspaceDir = process.cwd()
|
|
const cacheFile = getFilePath(workspaceDir)
|
|
fs.mkdirSync(path.dirname(cacheFile), { recursive: true })
|
|
expect(loadWorkspaceState(workspaceDir)).toBeUndefined()
|
|
expect(jest.mocked(logger.debug).mock.calls).toStrictEqual(expectedLoggerCalls)
|
|
})
|
|
|
|
test('loadWorkspaceState() when cache file exists and is correct', async () => {
|
|
prepareEmpty()
|
|
|
|
const workspaceDir = process.cwd()
|
|
const cacheFile = getFilePath(workspaceDir)
|
|
fs.mkdirSync(path.dirname(cacheFile), { recursive: true })
|
|
const workspaceState: WorkspaceState = {
|
|
settings: {
|
|
autoInstallPeers: true,
|
|
dedupeDirectDeps: true,
|
|
excludeLinksFromLockfile: false,
|
|
preferWorkspacePackages: false,
|
|
injectWorkspacePackages: false,
|
|
catalogs: {
|
|
default: {
|
|
foo: '0.1.2',
|
|
},
|
|
},
|
|
linkWorkspacePackages: true,
|
|
},
|
|
lastValidatedTimestamp,
|
|
projects: {
|
|
[path.resolve('packages/a') as ProjectRootDir]: {},
|
|
[path.resolve('packages/b') as ProjectRootDir]: {},
|
|
[path.resolve('packages/c') as ProjectRootDir]: {},
|
|
[path.resolve('packages/d') as ProjectRootDir]: {},
|
|
},
|
|
pnpmfiles: [],
|
|
filteredInstall: false,
|
|
}
|
|
fs.writeFileSync(cacheFile, JSON.stringify(workspaceState))
|
|
expect(loadWorkspaceState(workspaceDir)).toStrictEqual(workspaceState)
|
|
expect(jest.mocked(logger.debug).mock.calls).toStrictEqual(expectedLoggerCalls)
|
|
})
|