mirror of
https://github.com/pnpm/pnpm.git
synced 2026-07-21 21:22:26 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
419 lines
13 KiB
TypeScript
419 lines
13 KiB
TypeScript
import path from 'node:path'
|
|
|
|
import { expect, test } from '@jest/globals'
|
|
import { assertProject } from '@pnpm/assert-project'
|
|
import { rebuild } from '@pnpm/building.commands'
|
|
import { preparePackages } from '@pnpm/prepare'
|
|
import { createTestIpcServer } from '@pnpm/test-ipc-server'
|
|
import type { PackageManifest } from '@pnpm/types'
|
|
import { filterProjectsBySelectorObjectsFromDir } from '@pnpm/workspace.projects-filter'
|
|
import { safeExeca as execa } from 'execa'
|
|
import { writeYamlFileSync } from 'write-yaml-file'
|
|
|
|
import { DEFAULT_OPTS, REGISTRY } from './utils/index.js'
|
|
|
|
const pnpmBin = path.join(import.meta.dirname, '../../../../pnpm/bin/pnpm.mjs')
|
|
|
|
test('pnpm recursive rebuild', async () => {
|
|
const projects = preparePackages([
|
|
{
|
|
name: 'project-1',
|
|
version: '1.0.0',
|
|
|
|
dependencies: {
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example': '*',
|
|
},
|
|
},
|
|
{
|
|
name: 'project-2',
|
|
version: '1.0.0',
|
|
|
|
dependencies: {
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example': '*',
|
|
},
|
|
},
|
|
])
|
|
|
|
const { allProjects, selectedProjectsGraph } = await filterProjectsBySelectorObjectsFromDir(process.cwd(), [])
|
|
await execa('node', [
|
|
pnpmBin,
|
|
'install',
|
|
'-r',
|
|
`--registry=${REGISTRY}`,
|
|
`--store-dir=${path.resolve(DEFAULT_OPTS.storeDir)}`,
|
|
`--cache-dir=${path.resolve(DEFAULT_OPTS.cacheDir)}`,
|
|
'--ignore-scripts',
|
|
'--reporter=append-only',
|
|
'--config.enableGlobalVirtualStore=false',
|
|
], { stdout: 'inherit' })
|
|
|
|
projects['project-1'].hasNot('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js')
|
|
projects['project-1'].hasNot('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js')
|
|
projects['project-2'].hasNot('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js')
|
|
projects['project-2'].hasNot('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js')
|
|
|
|
const modulesManifest = projects['project-1'].readModulesManifest()
|
|
await rebuild.handler({
|
|
...DEFAULT_OPTS,
|
|
allProjects,
|
|
dir: process.cwd(),
|
|
recursive: true,
|
|
registries: modulesManifest!.registries!,
|
|
selectedProjectsGraph,
|
|
workspaceDir: process.cwd(),
|
|
allowBuilds: { '@pnpm.e2e/pre-and-postinstall-scripts-example': true },
|
|
}, [])
|
|
|
|
projects['project-1'].has('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js')
|
|
projects['project-1'].has('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js')
|
|
projects['project-2'].has('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js')
|
|
projects['project-2'].has('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js')
|
|
})
|
|
|
|
test('pnpm recursive rebuild with hoisted node linker', async () => {
|
|
const projects = preparePackages([
|
|
{
|
|
name: 'project-1',
|
|
version: '1.0.0',
|
|
|
|
dependencies: {
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example': '1',
|
|
},
|
|
},
|
|
{
|
|
name: 'project-2',
|
|
version: '1.0.0',
|
|
|
|
dependencies: {
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example': '1',
|
|
},
|
|
},
|
|
{
|
|
name: 'project-3',
|
|
version: '1.0.0',
|
|
|
|
dependencies: {
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example': '2',
|
|
},
|
|
},
|
|
{
|
|
name: 'project-4',
|
|
version: '1.0.0',
|
|
|
|
dependencies: {
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example': '2',
|
|
},
|
|
},
|
|
])
|
|
|
|
const { allProjects, selectedProjectsGraph } = await filterProjectsBySelectorObjectsFromDir(process.cwd(), [])
|
|
writeYamlFileSync('pnpm-workspace.yaml', { packages: ['*'] })
|
|
await execa('node', [
|
|
pnpmBin,
|
|
'install',
|
|
'-r',
|
|
`--registry=${REGISTRY}`,
|
|
`--store-dir=${path.resolve(DEFAULT_OPTS.storeDir)}`,
|
|
`--cache-dir=${path.resolve(DEFAULT_OPTS.cacheDir)}`,
|
|
'--ignore-scripts',
|
|
'--reporter=append-only',
|
|
'--config.node-linker=hoisted',
|
|
'--config.enableGlobalVirtualStore=false',
|
|
], { stdout: 'inherit' })
|
|
|
|
const rootProject = assertProject(process.cwd())
|
|
rootProject.hasNot('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js')
|
|
rootProject.hasNot('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js')
|
|
projects['project-3'].hasNot('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js')
|
|
projects['project-3'].hasNot('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js')
|
|
projects['project-4'].hasNot('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js')
|
|
projects['project-4'].hasNot('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js')
|
|
|
|
const modulesManifest = rootProject.readModulesManifest()
|
|
await rebuild.handler({
|
|
...DEFAULT_OPTS,
|
|
allProjects,
|
|
dir: process.cwd(),
|
|
nodeLinker: 'hoisted',
|
|
recursive: true,
|
|
registries: modulesManifest!.registries!,
|
|
selectedProjectsGraph,
|
|
lockfileDir: process.cwd(),
|
|
workspaceDir: process.cwd(),
|
|
allowBuilds: { '@pnpm.e2e/pre-and-postinstall-scripts-example': true },
|
|
}, [])
|
|
|
|
rootProject.has('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js')
|
|
rootProject.has('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js')
|
|
projects['project-1'].hasNot('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js')
|
|
projects['project-1'].hasNot('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js')
|
|
projects['project-2'].hasNot('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js')
|
|
projects['project-2'].hasNot('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js')
|
|
projects['project-3'].has('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js')
|
|
projects['project-3'].has('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js')
|
|
projects['project-4'].has('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js')
|
|
projects['project-4'].has('@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js')
|
|
})
|
|
|
|
test('rebuild multiple packages in correct order', async () => {
|
|
await using server1 = await createTestIpcServer()
|
|
await using server2 = await createTestIpcServer()
|
|
|
|
const pkgs: Array<PackageManifest & { name: string }> = [
|
|
{
|
|
name: 'project-1',
|
|
version: '1.0.0',
|
|
|
|
scripts: {
|
|
postinstall: `${server1.sendLineScript('project-1')} && ${server2.sendLineScript('project-1')}`,
|
|
},
|
|
},
|
|
{
|
|
name: 'project-2',
|
|
version: '1.0.0',
|
|
|
|
dependencies: {
|
|
'project-1': '1',
|
|
},
|
|
scripts: {
|
|
postinstall: server1.sendLineScript('project-2'),
|
|
},
|
|
},
|
|
{
|
|
name: 'project-3',
|
|
version: '1.0.0',
|
|
|
|
dependencies: {
|
|
'project-1': '1',
|
|
},
|
|
scripts: {
|
|
postinstall: server2.sendLineScript('project-3'),
|
|
},
|
|
},
|
|
{
|
|
name: 'project-0',
|
|
version: '1.0.0',
|
|
|
|
dependencies: {},
|
|
},
|
|
]
|
|
preparePackages(pkgs)
|
|
writeYamlFileSync('pnpm-workspace.yaml', { packages: pkgs.map(pkg => pkg.name) })
|
|
|
|
const { allProjects, selectedProjectsGraph } = await filterProjectsBySelectorObjectsFromDir(process.cwd(), [])
|
|
await execa('node', [
|
|
pnpmBin,
|
|
'install',
|
|
'-r',
|
|
'--registry',
|
|
REGISTRY,
|
|
'--store-dir',
|
|
path.resolve(DEFAULT_OPTS.storeDir),
|
|
'--ignore-scripts',
|
|
'--config.enableGlobalVirtualStore=false',
|
|
])
|
|
|
|
await rebuild.handler({
|
|
...DEFAULT_OPTS,
|
|
allProjects,
|
|
dir: process.cwd(),
|
|
recursive: true,
|
|
selectedProjectsGraph,
|
|
workspaceDir: process.cwd(),
|
|
allowBuilds: { 'project-1': true, 'project-2': true, 'project-3': true },
|
|
}, [])
|
|
|
|
expect(server1.getLines()).toStrictEqual(['project-1', 'project-2'])
|
|
expect(server2.getLines()).toStrictEqual(['project-1', 'project-3'])
|
|
})
|
|
|
|
test('only build allowBuilds (not others)', async () => {
|
|
const projects = preparePackages([
|
|
{
|
|
name: 'project-1',
|
|
version: '1.0.0',
|
|
|
|
dependencies: {
|
|
'@pnpm.e2e/install-script-example': '*',
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example': '*',
|
|
},
|
|
},
|
|
{
|
|
name: 'project-2',
|
|
version: '1.0.0',
|
|
|
|
dependencies: {
|
|
'@pnpm.e2e/install-script-example': '*',
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example': '*',
|
|
},
|
|
},
|
|
])
|
|
|
|
const { allProjects, selectedProjectsGraph } = await filterProjectsBySelectorObjectsFromDir(
|
|
process.cwd(),
|
|
[]
|
|
)
|
|
await execa(
|
|
'node',
|
|
[
|
|
pnpmBin,
|
|
'install',
|
|
'-r',
|
|
`--registry=${REGISTRY}`,
|
|
`--store-dir=${path.resolve(DEFAULT_OPTS.storeDir)}`,
|
|
`--cache-dir=${path.resolve(DEFAULT_OPTS.cacheDir)}`,
|
|
'--ignore-scripts',
|
|
'--reporter=append-only',
|
|
'--config.enableGlobalVirtualStore=false',
|
|
],
|
|
{ stdout: 'inherit' }
|
|
)
|
|
projects['project-1'].hasNot(
|
|
'@pnpm.e2e/install-script-example/generated-by-install.js'
|
|
)
|
|
projects['project-2'].hasNot(
|
|
'@pnpm.e2e/install-script-example/generated-by-install.js'
|
|
)
|
|
projects['project-1'].hasNot(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js'
|
|
)
|
|
projects['project-1'].hasNot(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js'
|
|
)
|
|
projects['project-2'].hasNot(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js'
|
|
)
|
|
projects['project-2'].hasNot(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js'
|
|
)
|
|
|
|
const modulesManifest = projects['project-1'].readModulesManifest()
|
|
await rebuild.handler(
|
|
{
|
|
...DEFAULT_OPTS,
|
|
allowBuilds: { '@pnpm.e2e/install-script-example': true },
|
|
allProjects,
|
|
dir: process.cwd(),
|
|
recursive: true,
|
|
registries: modulesManifest!.registries!,
|
|
selectedProjectsGraph,
|
|
workspaceDir: process.cwd(),
|
|
},
|
|
[]
|
|
)
|
|
|
|
projects['project-1'].has(
|
|
'@pnpm.e2e/install-script-example/generated-by-install.js'
|
|
)
|
|
projects['project-2'].has(
|
|
'@pnpm.e2e/install-script-example/generated-by-install.js'
|
|
)
|
|
projects['project-1'].hasNot(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js'
|
|
)
|
|
projects['project-1'].hasNot(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js'
|
|
)
|
|
projects['project-2'].hasNot(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js'
|
|
)
|
|
projects['project-2'].hasNot(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js'
|
|
)
|
|
})
|
|
|
|
test('only build allowBuilds', async () => {
|
|
const projects = preparePackages([
|
|
{
|
|
name: 'project-1',
|
|
version: '1.0.0',
|
|
|
|
dependencies: {
|
|
'@pnpm.e2e/install-script-example': '*',
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example': '*',
|
|
},
|
|
},
|
|
{
|
|
name: 'project-2',
|
|
version: '1.0.0',
|
|
|
|
dependencies: {
|
|
'@pnpm.e2e/install-script-example': '*',
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example': '*',
|
|
},
|
|
},
|
|
])
|
|
|
|
const { allProjects, selectedProjectsGraph } = await filterProjectsBySelectorObjectsFromDir(
|
|
process.cwd(),
|
|
[]
|
|
)
|
|
await execa(
|
|
'node',
|
|
[
|
|
pnpmBin,
|
|
'install',
|
|
'-r',
|
|
`--registry=${REGISTRY}`,
|
|
`--store-dir=${path.resolve(DEFAULT_OPTS.storeDir)}`,
|
|
`--cache-dir=${path.resolve(DEFAULT_OPTS.cacheDir)}`,
|
|
'--ignore-scripts',
|
|
'--reporter=append-only',
|
|
'--config.enableGlobalVirtualStore=false',
|
|
],
|
|
{ stdout: 'inherit' }
|
|
)
|
|
projects['project-1'].hasNot(
|
|
'@pnpm.e2e/install-script-example/generated-by-install.js'
|
|
)
|
|
projects['project-2'].hasNot(
|
|
'@pnpm.e2e/install-script-example/generated-by-install.js'
|
|
)
|
|
projects['project-1'].hasNot(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js'
|
|
)
|
|
projects['project-1'].hasNot(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js'
|
|
)
|
|
projects['project-2'].hasNot(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js'
|
|
)
|
|
projects['project-2'].hasNot(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js'
|
|
)
|
|
|
|
const modulesManifest = projects['project-1'].readModulesManifest()
|
|
await rebuild.handler(
|
|
{
|
|
...DEFAULT_OPTS,
|
|
allowBuilds: { '@pnpm.e2e/pre-and-postinstall-scripts-example': true },
|
|
allProjects,
|
|
dir: process.cwd(),
|
|
recursive: true,
|
|
registries: modulesManifest!.registries!,
|
|
selectedProjectsGraph,
|
|
workspaceDir: process.cwd(),
|
|
},
|
|
[]
|
|
)
|
|
|
|
projects['project-1'].hasNot(
|
|
'@pnpm.e2e/install-script-example/generated-by-install.js'
|
|
)
|
|
projects['project-2'].hasNot(
|
|
'@pnpm.e2e/install-script-example/generated-by-install.js'
|
|
)
|
|
projects['project-1'].has(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js'
|
|
)
|
|
projects['project-1'].has(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js'
|
|
)
|
|
projects['project-2'].has(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-preinstall.js'
|
|
)
|
|
projects['project-2'].has(
|
|
'@pnpm.e2e/pre-and-postinstall-scripts-example/generated-by-postinstall.js'
|
|
)
|
|
})
|