mirror of
https://github.com/pnpm/pnpm.git
synced 2026-07-21 21:22:26 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
262 lines
6.7 KiB
TypeScript
262 lines
6.7 KiB
TypeScript
import path from 'node:path'
|
|
|
|
import { describe, expect, it } from '@jest/globals'
|
|
import { config } from '@pnpm/config.commands'
|
|
import { tempDir } from '@pnpm/prepare'
|
|
|
|
import { createConfigCommandOpts } from './utils/index.js'
|
|
import { type ConfigFilesData, readConfigFiles, writeConfigFiles } from './utils/index.js'
|
|
|
|
describe.each(
|
|
[
|
|
'_auth',
|
|
'_authToken',
|
|
'_password',
|
|
'username',
|
|
'registry',
|
|
'//registry.npmjs.org/:_authToken',
|
|
]
|
|
)('auth settings are written to the rc file directly', (key) => {
|
|
describe('global (without --json)', () => {
|
|
it(`should set ${key}`, async () => {
|
|
const tmp = tempDir()
|
|
const configDir = path.join(tmp, 'global-config')
|
|
const initConfig = {
|
|
globalRc: {},
|
|
globalYaml: undefined,
|
|
localRc: undefined,
|
|
localYaml: undefined,
|
|
} satisfies ConfigFilesData
|
|
writeConfigFiles(configDir, tmp, initConfig)
|
|
|
|
await config.handler(createConfigCommandOpts({
|
|
dir: tmp,
|
|
cliOptions: {},
|
|
configDir,
|
|
global: true,
|
|
authConfig: {},
|
|
}), ['set', `${key}=123`])
|
|
|
|
expect(readConfigFiles(configDir, tmp)).toEqual({
|
|
...initConfig,
|
|
globalRc: { [key]: '123' },
|
|
})
|
|
})
|
|
it(`should delete ${key}`, async () => {
|
|
const tmp = tempDir()
|
|
const configDir = path.join(tmp, 'global-config')
|
|
const initConfig = {
|
|
globalRc: { [key]: 'some-value' },
|
|
globalYaml: undefined,
|
|
localRc: undefined,
|
|
localYaml: undefined,
|
|
} satisfies ConfigFilesData
|
|
writeConfigFiles(configDir, tmp, initConfig)
|
|
|
|
await config.handler(createConfigCommandOpts({
|
|
dir: tmp,
|
|
cliOptions: {},
|
|
configDir,
|
|
global: true,
|
|
authConfig: {},
|
|
}), ['delete', key])
|
|
|
|
expect(readConfigFiles(configDir, tmp)).toEqual({
|
|
...initConfig,
|
|
globalRc: {},
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('global (with --json)', () => {
|
|
it(`should set ${key}`, async () => {
|
|
const tmp = tempDir()
|
|
const configDir = path.join(tmp, 'global-config')
|
|
const initConfig = {
|
|
globalRc: {},
|
|
globalYaml: undefined,
|
|
localRc: undefined,
|
|
localYaml: undefined,
|
|
} satisfies ConfigFilesData
|
|
writeConfigFiles(configDir, tmp, initConfig)
|
|
|
|
await config.handler(createConfigCommandOpts({
|
|
json: true,
|
|
dir: tmp,
|
|
cliOptions: {},
|
|
configDir,
|
|
global: true,
|
|
authConfig: {},
|
|
}), ['set', key, '"123"'])
|
|
|
|
expect(readConfigFiles(configDir, tmp)).toEqual({
|
|
...initConfig,
|
|
globalRc: { [key]: '123' },
|
|
})
|
|
})
|
|
it(`should delete ${key}`, async () => {
|
|
const tmp = tempDir()
|
|
const configDir = path.join(tmp, 'global-config')
|
|
const initConfig = {
|
|
globalRc: { [key]: 'some-value' },
|
|
globalYaml: undefined,
|
|
localRc: undefined,
|
|
localYaml: undefined,
|
|
} satisfies ConfigFilesData
|
|
writeConfigFiles(configDir, tmp, initConfig)
|
|
|
|
await config.handler(createConfigCommandOpts({
|
|
json: true,
|
|
dir: tmp,
|
|
cliOptions: {},
|
|
configDir,
|
|
global: true,
|
|
authConfig: {},
|
|
}), ['delete', key])
|
|
|
|
expect(readConfigFiles(configDir, tmp)).toEqual({
|
|
...initConfig,
|
|
globalRc: {},
|
|
})
|
|
})
|
|
})
|
|
})
|
|
|
|
describe.each(
|
|
[
|
|
'@foo:registry',
|
|
]
|
|
)('scoped auth settings are written to the rc file directly', (key) => {
|
|
it(`should set ${key} globally`, async () => {
|
|
const tmp = tempDir()
|
|
const configDir = path.join(tmp, 'global-config')
|
|
const initConfig = {
|
|
globalRc: {},
|
|
globalYaml: undefined,
|
|
localRc: undefined,
|
|
localYaml: undefined,
|
|
} satisfies ConfigFilesData
|
|
writeConfigFiles(configDir, tmp, initConfig)
|
|
|
|
await config.handler(createConfigCommandOpts({
|
|
dir: tmp,
|
|
cliOptions: {},
|
|
configDir,
|
|
global: true,
|
|
authConfig: {},
|
|
}), ['set', `${key}=https://registry.example.com/`])
|
|
|
|
expect(readConfigFiles(configDir, tmp)).toEqual({
|
|
...initConfig,
|
|
globalRc: { [key]: 'https://registry.example.com/' },
|
|
})
|
|
})
|
|
it(`should delete ${key} globally`, async () => {
|
|
const tmp = tempDir()
|
|
const configDir = path.join(tmp, 'global-config')
|
|
const initConfig = {
|
|
globalRc: { [key]: 'https://registry.example.com/' },
|
|
globalYaml: undefined,
|
|
localRc: undefined,
|
|
localYaml: undefined,
|
|
} satisfies ConfigFilesData
|
|
writeConfigFiles(configDir, tmp, initConfig)
|
|
|
|
await config.handler(createConfigCommandOpts({
|
|
dir: tmp,
|
|
cliOptions: {},
|
|
configDir,
|
|
global: true,
|
|
authConfig: {},
|
|
}), ['delete', key])
|
|
|
|
expect(readConfigFiles(configDir, tmp)).toEqual({
|
|
...initConfig,
|
|
globalRc: {},
|
|
})
|
|
})
|
|
})
|
|
|
|
describe.each(
|
|
[
|
|
'_auth',
|
|
'_authToken',
|
|
'_password',
|
|
'username',
|
|
'registry',
|
|
'@foo:registry',
|
|
'//registry.npmjs.org/:_authToken',
|
|
]
|
|
)('non-string values should be rejected', (key) => {
|
|
const tmp = tempDir()
|
|
const configDir = path.join(tmp, 'global-config')
|
|
it(`${key} should reject a non-string value`, async () => {
|
|
await expect(config.handler(createConfigCommandOpts({
|
|
json: true,
|
|
dir: tmp,
|
|
cliOptions: {},
|
|
configDir,
|
|
global: true,
|
|
authConfig: {},
|
|
}), ['set', key, '{}'])).rejects.toMatchObject({
|
|
code: 'ERR_PNPM_CONFIG_SET_AUTH_NON_STRING',
|
|
})
|
|
})
|
|
})
|
|
|
|
describe.each(
|
|
[
|
|
'._auth',
|
|
"['_auth']",
|
|
]
|
|
)('%p is handled as an auth setting', (propertyPath) => {
|
|
it('should set _auth', async () => {
|
|
const tmp = tempDir()
|
|
const configDir = path.join(tmp, 'global-config')
|
|
const initConfig = {
|
|
globalRc: {},
|
|
globalYaml: undefined,
|
|
localRc: undefined,
|
|
localYaml: undefined,
|
|
} satisfies ConfigFilesData
|
|
writeConfigFiles(configDir, tmp, initConfig)
|
|
|
|
await config.handler(createConfigCommandOpts({
|
|
dir: tmp,
|
|
cliOptions: {},
|
|
configDir,
|
|
global: true,
|
|
authConfig: {},
|
|
}), ['set', propertyPath, '123'])
|
|
|
|
expect(readConfigFiles(configDir, tmp)).toEqual({
|
|
...initConfig,
|
|
globalRc: { _auth: '123' },
|
|
})
|
|
})
|
|
it('should delete _auth', async () => {
|
|
const tmp = tempDir()
|
|
const configDir = path.join(tmp, 'global-config')
|
|
const initConfig = {
|
|
globalRc: { _auth: 'some-value' },
|
|
globalYaml: undefined,
|
|
localRc: undefined,
|
|
localYaml: undefined,
|
|
} satisfies ConfigFilesData
|
|
writeConfigFiles(configDir, tmp, initConfig)
|
|
|
|
await config.handler(createConfigCommandOpts({
|
|
dir: tmp,
|
|
cliOptions: {},
|
|
configDir,
|
|
global: true,
|
|
authConfig: {},
|
|
}), ['delete', propertyPath])
|
|
|
|
expect(readConfigFiles(configDir, tmp)).toEqual({
|
|
...initConfig,
|
|
globalRc: {},
|
|
})
|
|
})
|
|
})
|