mirror of
https://github.com/pnpm/pnpm.git
synced 2026-07-21 13:12:46 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
93 lines
2.5 KiB
TypeScript
93 lines
2.5 KiB
TypeScript
/// <reference path="../../../__typings__/index.d.ts"/>
|
|
import fs from 'node:fs'
|
|
import { homedir } from 'node:os'
|
|
import path from 'node:path'
|
|
|
|
import { expect, test } from '@jest/globals'
|
|
import { getConfig } from '@pnpm/config.reader'
|
|
import { tempDir } from '@pnpm/prepare'
|
|
import pathName from 'path-name'
|
|
import { symlinkDir } from 'symlink-dir'
|
|
|
|
const globalBinDir = path.join(homedir(), '.local', 'pnpm')
|
|
|
|
test('respects global-bin-dir from CLI', async () => {
|
|
const { config } = await getConfig({
|
|
cliOptions: {
|
|
global: true,
|
|
'global-bin-dir': globalBinDir,
|
|
},
|
|
env: {
|
|
[pathName]: `${globalBinDir}${path.delimiter}${process.env[pathName]!}`,
|
|
},
|
|
packageManager: {
|
|
name: 'pnpm',
|
|
version: '1.0.0',
|
|
},
|
|
})
|
|
expect(config.bin).toBe(globalBinDir)
|
|
})
|
|
|
|
test('respects global-bin-dir rather than dir', async () => {
|
|
const { config } = await getConfig({
|
|
cliOptions: {
|
|
global: true,
|
|
'global-bin-dir': globalBinDir,
|
|
dir: import.meta.dirname,
|
|
},
|
|
env: {
|
|
[pathName]: `${globalBinDir}${path.delimiter}${process.env[pathName]!}`,
|
|
},
|
|
packageManager: {
|
|
name: 'pnpm',
|
|
version: '1.0.0',
|
|
},
|
|
})
|
|
expect(config.bin).toBe(globalBinDir)
|
|
})
|
|
|
|
test('an exception is thrown when the global dir is not in PATH', async () => {
|
|
const tmp = tempDir()
|
|
const binDir = path.join(tmp, 'not-in-path-bin')
|
|
fs.mkdirSync(binDir, { recursive: true })
|
|
await expect(
|
|
getConfig({
|
|
cliOptions: {
|
|
global: true,
|
|
'global-bin-dir': binDir,
|
|
dir: import.meta.dirname,
|
|
},
|
|
env: {
|
|
[pathName]: process.env[pathName],
|
|
},
|
|
packageManager: {
|
|
name: 'pnpm',
|
|
version: '1.0.0',
|
|
},
|
|
})
|
|
).rejects.toThrow(/is not in PATH/)
|
|
})
|
|
|
|
test('the global directory may be a symlink to a directory that is in PATH', async () => {
|
|
const tmp = tempDir()
|
|
const globalBinDirTarget = path.join(tmp, 'global-target')
|
|
fs.mkdirSync(globalBinDirTarget)
|
|
const globalBinDirSymlink = path.join(tmp, 'global-symlink')
|
|
await symlinkDir(globalBinDirTarget, globalBinDirSymlink)
|
|
const { config } = await getConfig({
|
|
cliOptions: {
|
|
global: true,
|
|
'global-bin-dir': globalBinDirSymlink,
|
|
dir: import.meta.dirname,
|
|
},
|
|
env: {
|
|
[pathName]: `${globalBinDirTarget}${path.delimiter}${process.env[pathName]!}`,
|
|
},
|
|
packageManager: {
|
|
name: 'pnpm',
|
|
version: '1.0.0',
|
|
},
|
|
})
|
|
expect(config.bin).toBe(globalBinDirSymlink)
|
|
})
|