mirror of
https://github.com/pnpm/pnpm.git
synced 2026-07-22 05:32:44 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
260 lines
7.0 KiB
TypeScript
260 lines
7.0 KiB
TypeScript
import path from 'node:path'
|
|
|
|
import { test } from '@jest/globals'
|
|
import { addDependenciesToPackage, install } from '@pnpm/installing.deps-installer'
|
|
import { prepareEmpty } from '@pnpm/prepare'
|
|
import { addUser, REGISTRY_MOCK_PORT } from '@pnpm/registry-mock'
|
|
import type { RegistryConfig } from '@pnpm/types'
|
|
import { rimrafSync } from '@zkochan/rimraf'
|
|
|
|
import { testDefaults } from '../utils/index.js'
|
|
|
|
const skipOnNode17 = ['v14', 'v16'].includes(process.version.split('.')[0]) ? test : test.skip
|
|
|
|
test('a package that need authentication', async () => {
|
|
const project = prepareEmpty()
|
|
|
|
const data = await addUser({
|
|
email: 'foo@bar.com',
|
|
password: 'bar',
|
|
username: 'foo',
|
|
})
|
|
|
|
let configByUri: Record<string, RegistryConfig> = {
|
|
[`//localhost:${REGISTRY_MOCK_PORT}/`]: { creds: { authToken: data.token } },
|
|
}
|
|
const { updatedManifest: manifest } = await addDependenciesToPackage({}, ['@pnpm.e2e/needs-auth'], testDefaults({}, {
|
|
configByUri,
|
|
}, {
|
|
configByUri,
|
|
}))
|
|
|
|
project.has('@pnpm.e2e/needs-auth')
|
|
|
|
// should work when a lockfile is available
|
|
// and the registry in .npmrc is not the same as the one in lockfile
|
|
rimrafSync('node_modules')
|
|
rimrafSync(path.join('..', '.store'))
|
|
|
|
configByUri = {
|
|
[`//localhost:${REGISTRY_MOCK_PORT}/`]: { creds: { authToken: data.token } },
|
|
}
|
|
await addDependenciesToPackage(manifest, ['@pnpm.e2e/needs-auth'], testDefaults({}, {
|
|
configByUri,
|
|
registry: 'https://registry.npmjs.org/',
|
|
}, {
|
|
configByUri,
|
|
}))
|
|
|
|
project.has('@pnpm.e2e/needs-auth')
|
|
})
|
|
|
|
test('installing a package that need authentication, using password', async () => {
|
|
const project = prepareEmpty()
|
|
|
|
await addUser({
|
|
email: 'foo@bar.com',
|
|
password: 'bar',
|
|
username: 'foo',
|
|
})
|
|
|
|
const configByUri: Record<string, RegistryConfig> = {
|
|
[`//localhost:${REGISTRY_MOCK_PORT}/`]: { creds: { basicAuth: { username: 'foo', password: 'bar' } } },
|
|
}
|
|
await addDependenciesToPackage({}, ['@pnpm.e2e/needs-auth'], testDefaults({}, {
|
|
configByUri,
|
|
}, {
|
|
configByUri,
|
|
}))
|
|
|
|
project.has('@pnpm.e2e/needs-auth')
|
|
})
|
|
|
|
test('a package that need authentication, legacy way', async () => {
|
|
const project = prepareEmpty()
|
|
|
|
await addUser({
|
|
email: 'foo@bar.com',
|
|
password: 'bar',
|
|
username: 'foo',
|
|
})
|
|
|
|
const configByUri: Record<string, RegistryConfig> = {
|
|
'': { creds: { basicAuth: { username: 'foo', password: 'bar' } } },
|
|
}
|
|
await addDependenciesToPackage({}, ['@pnpm.e2e/needs-auth'], testDefaults({}, {
|
|
configByUri,
|
|
}, {
|
|
configByUri,
|
|
}))
|
|
|
|
project.has('@pnpm.e2e/needs-auth')
|
|
})
|
|
|
|
test('a scoped package that need authentication specific to scope', async () => {
|
|
const project = prepareEmpty()
|
|
|
|
const data = await addUser({
|
|
email: 'foo@bar.com',
|
|
password: 'bar',
|
|
username: 'foo',
|
|
})
|
|
|
|
const configByUri: Record<string, RegistryConfig> = {
|
|
[`//localhost:${REGISTRY_MOCK_PORT}/`]: { creds: { authToken: data.token } },
|
|
}
|
|
let opts = testDefaults({
|
|
registries: {
|
|
default: 'https://registry.npmjs.org/',
|
|
'@private': `http://localhost:${REGISTRY_MOCK_PORT}/`,
|
|
},
|
|
}, {
|
|
configByUri,
|
|
registry: 'https://registry.npmjs.org/',
|
|
}, {
|
|
configByUri,
|
|
})
|
|
const { updatedManifest: manifest } = await addDependenciesToPackage({}, ['@private/foo'], opts)
|
|
|
|
project.has('@private/foo')
|
|
|
|
// should work when a lockfile is available
|
|
rimrafSync('node_modules')
|
|
rimrafSync(path.join('..', '.store'))
|
|
|
|
// Recreating options to have a new storeController with clean cache
|
|
opts = testDefaults({
|
|
registries: {
|
|
default: 'https://registry.npmjs.org/',
|
|
'@private': `http://localhost:${REGISTRY_MOCK_PORT}/`,
|
|
},
|
|
}, {
|
|
configByUri,
|
|
registry: 'https://registry.npmjs.org/',
|
|
}, {
|
|
configByUri,
|
|
})
|
|
await addDependenciesToPackage(manifest, ['@private/foo'], opts)
|
|
|
|
project.has('@private/foo')
|
|
})
|
|
|
|
test('a scoped package that need legacy authentication specific to scope', async () => {
|
|
const project = prepareEmpty()
|
|
|
|
await addUser({
|
|
email: 'foo@bar.com',
|
|
password: 'bar',
|
|
username: 'foo',
|
|
})
|
|
|
|
const configByUri: Record<string, RegistryConfig> = {
|
|
[`//localhost:${REGISTRY_MOCK_PORT}/`]: { creds: { basicAuth: { username: 'foo', password: 'bar' } } },
|
|
}
|
|
let opts = testDefaults({
|
|
registries: {
|
|
default: 'https://registry.npmjs.org/',
|
|
'@private': `http://localhost:${REGISTRY_MOCK_PORT}/`,
|
|
},
|
|
}, {
|
|
configByUri,
|
|
registry: 'https://registry.npmjs.org/',
|
|
}, {
|
|
configByUri,
|
|
})
|
|
const { updatedManifest: manifest } = await addDependenciesToPackage({}, ['@private/foo'], opts)
|
|
|
|
project.has('@private/foo')
|
|
|
|
// should work when a lockfile is available
|
|
rimrafSync('node_modules')
|
|
rimrafSync(path.join('..', '.store'))
|
|
|
|
// Recreating options to have a new storeController with clean cache
|
|
opts = testDefaults({
|
|
registries: {
|
|
default: 'https://registry.npmjs.org/',
|
|
'@private': `http://localhost:${REGISTRY_MOCK_PORT}/`,
|
|
},
|
|
}, {
|
|
configByUri,
|
|
registry: 'https://registry.npmjs.org/',
|
|
}, {
|
|
configByUri,
|
|
})
|
|
await addDependenciesToPackage(manifest, ['@private/foo'], opts)
|
|
|
|
project.has('@private/foo')
|
|
})
|
|
|
|
skipOnNode17('a package that need authentication reuses authorization tokens for tarball fetching', async () => {
|
|
const project = prepareEmpty()
|
|
|
|
const data = await addUser({
|
|
email: 'foo@bar.com',
|
|
password: 'bar',
|
|
username: 'foo',
|
|
})
|
|
|
|
const configByUri: Record<string, RegistryConfig> = {
|
|
[`//127.0.0.1:${REGISTRY_MOCK_PORT}/`]: { creds: { authToken: data.token } },
|
|
}
|
|
await addDependenciesToPackage({}, ['@pnpm.e2e/needs-auth'], testDefaults({
|
|
registries: {
|
|
default: `http://127.0.0.1:${REGISTRY_MOCK_PORT}`,
|
|
},
|
|
}, {
|
|
configByUri,
|
|
registry: `http://127.0.0.1:${REGISTRY_MOCK_PORT}`,
|
|
}, {
|
|
configByUri,
|
|
}))
|
|
|
|
project.has('@pnpm.e2e/needs-auth')
|
|
})
|
|
|
|
skipOnNode17('a package that need authentication reuses authorization tokens for tarball fetching when meta info is cached', async () => {
|
|
const project = prepareEmpty()
|
|
|
|
const data = await addUser({
|
|
email: 'foo@bar.com',
|
|
password: 'bar',
|
|
username: 'foo',
|
|
})
|
|
|
|
const configByUri: Record<string, RegistryConfig> = {
|
|
[`//127.0.0.1:${REGISTRY_MOCK_PORT}/`]: { creds: { authToken: data.token } },
|
|
}
|
|
let opts = testDefaults({
|
|
registries: {
|
|
default: `http://127.0.0.1:${REGISTRY_MOCK_PORT}`,
|
|
},
|
|
}, {
|
|
configByUri,
|
|
registry: `http://127.0.0.1:${REGISTRY_MOCK_PORT}`,
|
|
}, {
|
|
configByUri,
|
|
})
|
|
|
|
const { updatedManifest: manifest } = await addDependenciesToPackage({}, ['@pnpm.e2e/needs-auth'], opts)
|
|
|
|
rimrafSync('node_modules')
|
|
rimrafSync(path.join('..', '.registry'))
|
|
rimrafSync(path.join('..', '.store'))
|
|
|
|
// Recreating options to clean store cache
|
|
opts = testDefaults({
|
|
registries: {
|
|
default: `http://127.0.0.1:${REGISTRY_MOCK_PORT}`,
|
|
},
|
|
}, {
|
|
configByUri,
|
|
registry: `http://127.0.0.1:${REGISTRY_MOCK_PORT}`,
|
|
}, {
|
|
configByUri,
|
|
})
|
|
await install(manifest, opts)
|
|
|
|
project.has('@pnpm.e2e/needs-auth')
|
|
})
|